Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: webrtc/p2p/base/transportdescriptionfactory.h

Issue 2647593003: Accept SDP with TRANSPORT attributes missing from bundled m= sections. (Closed)
Patch Set: Fix "a=fingerprint" too. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/base/transportdescriptionfactory.h
diff --git a/webrtc/p2p/base/transportdescriptionfactory.h b/webrtc/p2p/base/transportdescriptionfactory.h
index 2dde5b12584b729f6a59963dedd76a82058fc942..8a530decb4b89435a236d418d45aa2316162b8f0 100644
--- a/webrtc/p2p/base/transportdescriptionfactory.h
+++ b/webrtc/p2p/base/transportdescriptionfactory.h
@@ -53,10 +53,15 @@ class TransportDescriptionFactory {
TransportDescription* CreateOffer(const TransportOptions& options,
const TransportDescription* current_description) const;
// Create a transport description that is a response to an offer.
+ // |bundled| indicates that this transport description is being generated
+ // for an m= section that's being bundled into another m= section, in
pthatcher1 2017/02/17 19:17:32 might be more clear as "|bundled| indicates that
Taylor Brandstetter 2017/02/17 21:49:14 Done.
+ // which case transport-level attributes aren't needed since they can
+ // be found in the other m= section.
TransportDescription* CreateAnswer(
const TransportDescription* offer,
const TransportOptions& options,
- const TransportDescription* current_description) const;
+ const TransportDescription* current_description,
+ bool bundled) const;
pthatcher1 2017/02/17 19:17:32 It ought to be the 3rd argument, not the last. An
Taylor Brandstetter 2017/02/17 21:49:14 Done (though not the TransportOptions part).
private:
bool SetSecurityInfo(TransportDescription* description,

Powered by Google App Engine
This is Rietveld 408576698