Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm

Issue 2646443013: iOS: Add MedianSlopeFilter field trial. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/sdk/objc/Framework/Headers/WebRTC/RTCFieldTrials.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #import "WebRTC/RTCFieldTrials.h" 11 #import "WebRTC/RTCFieldTrials.h"
12 12
13 #include <memory> 13 #include <memory>
14 14
15 #import "WebRTC/RTCLogging.h" 15 #import "WebRTC/RTCLogging.h"
16 16
17 #include "webrtc/system_wrappers/include/field_trial_default.h" 17 #include "webrtc/system_wrappers/include/field_trial_default.h"
18 18
19 NSString * const kRTCFieldTrialAudioSendSideBweKey = @"WebRTC-Audio-SendSideBwe" ; 19 NSString * const kRTCFieldTrialAudioSendSideBweKey = @"WebRTC-Audio-SendSideBwe" ;
20 NSString * const kRTCFieldTrialFlexFec03Key = @"WebRTC-FlexFEC-03"; 20 NSString * const kRTCFieldTrialFlexFec03Key = @"WebRTC-FlexFEC-03";
21 NSString * const kRTCFieldTrialImprovedBitrateEstimateKey = @"WebRTC-ImprovedBit rateEstimate"; 21 NSString * const kRTCFieldTrialImprovedBitrateEstimateKey = @"WebRTC-ImprovedBit rateEstimate";
22 NSString * const kRTCFieldTrialMedianSlopeFilterKey = @"WebRTC-BweMedianSlopeFil ter";
22 NSString * const kRTCFieldTrialTrendlineFilterKey = @"WebRTC-BweTrendlineFilter" ; 23 NSString * const kRTCFieldTrialTrendlineFilterKey = @"WebRTC-BweTrendlineFilter" ;
23 NSString * const kRTCFieldTrialH264HighProfileKey = @"WebRTC-H264HighProfile"; 24 NSString * const kRTCFieldTrialH264HighProfileKey = @"WebRTC-H264HighProfile";
24 NSString * const kRTCFieldTrialEnabledValue = @"Enabled"; 25 NSString * const kRTCFieldTrialEnabledValue = @"Enabled";
25 26
26 static std::unique_ptr<char[]> gFieldTrialInitString; 27 static std::unique_ptr<char[]> gFieldTrialInitString;
27 28
29 NSString *RTCFieldTrialMedianSlopeFilterValue(
30 size_t windowSize, double thresholdGain) {
31 NSString *format = @"Enabled-%zu,%lf";
32 return [NSString stringWithFormat:format, windowSize, thresholdGain];
33 }
34
28 NSString *RTCFieldTrialTrendlineFilterValue( 35 NSString *RTCFieldTrialTrendlineFilterValue(
29 size_t windowSize, double smoothingCoeff, double thresholdGain) { 36 size_t windowSize, double smoothingCoeff, double thresholdGain) {
30 NSString *format = @"Enabled-%zu,%lf,%lf"; 37 NSString *format = @"Enabled-%zu,%lf,%lf";
31 return [NSString stringWithFormat:format, windowSize, smoothingCoeff, threshol dGain]; 38 return [NSString stringWithFormat:format, windowSize, smoothingCoeff, threshol dGain];
32 } 39 }
33 40
34 void RTCInitFieldTrialDictionary(NSDictionary<NSString *, NSString *> *fieldTria ls) { 41 void RTCInitFieldTrialDictionary(NSDictionary<NSString *, NSString *> *fieldTria ls) {
35 if (!fieldTrials) { 42 if (!fieldTrials) {
36 RTCLogWarning(@"No fieldTrials provided."); 43 RTCLogWarning(@"No fieldTrials provided.");
37 return; 44 return;
38 } 45 }
39 // Assemble the keys and values into the field trial string. 46 // Assemble the keys and values into the field trial string.
40 // We don't perform any extra format checking. That should be done by the unde rlying WebRTC calls. 47 // We don't perform any extra format checking. That should be done by the unde rlying WebRTC calls.
41 NSMutableString *fieldTrialInitString = [NSMutableString string]; 48 NSMutableString *fieldTrialInitString = [NSMutableString string];
42 for (NSString *key in fieldTrials) { 49 for (NSString *key in fieldTrials) {
43 NSString *fieldTrialEntry = [NSString stringWithFormat:@"%@/%@/", key, field Trials[key]]; 50 NSString *fieldTrialEntry = [NSString stringWithFormat:@"%@/%@/", key, field Trials[key]];
44 [fieldTrialInitString appendString:fieldTrialEntry]; 51 [fieldTrialInitString appendString:fieldTrialEntry];
45 } 52 }
46 size_t len = fieldTrialInitString.length + 1; 53 size_t len = fieldTrialInitString.length + 1;
47 gFieldTrialInitString.reset(new char[len]); 54 gFieldTrialInitString.reset(new char[len]);
48 if (![fieldTrialInitString getCString:gFieldTrialInitString.get() 55 if (![fieldTrialInitString getCString:gFieldTrialInitString.get()
49 maxLength:len 56 maxLength:len
50 encoding:NSUTF8StringEncoding]) { 57 encoding:NSUTF8StringEncoding]) {
51 RTCLogError(@"Failed to convert field trial string."); 58 RTCLogError(@"Failed to convert field trial string.");
52 return; 59 return;
53 } 60 }
54 webrtc::field_trial::InitFieldTrialsFromString(gFieldTrialInitString.get()); 61 webrtc::field_trial::InitFieldTrialsFromString(gFieldTrialInitString.get());
55 } 62 }
OLDNEW
« no previous file with comments | « no previous file | webrtc/sdk/objc/Framework/Headers/WebRTC/RTCFieldTrials.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698