Creating libwebrtc bundle jar

webrtc/sdk/android/BUILD.gn

 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("//webrtc/build/webrtc.gni")
 import("//build/config/android/config.gni")
@@ skipping 92 matching lines @@
   suppressed_configs += [ "//build/config/android:hide_native_jni_exports" ]
 
   deps = [
     ":libjingle_peerconnection_jni",
     ":libjingle_peerconnection_metrics_default_jni",
     "//webrtc/api:libjingle_peerconnection",
   ]
   output_extension = "so"
 }
 
+dist_jar("libjingle_peerconnection_java_with_deps") {

[sakal, 2017/01/18 13:21:44]

Maybe a simpler name? I think this could even be called libwebrtc.

[mbonadei, 2017/01/19 08:30:45]

Yep, I agree.
I renamed the target to libwebrtc even if it is not aligned with the naming of
the surrounding targets.

[sakal, 2017/01/19 09:06:21]

I think the surrounding target names have just some legacy reasons behind them.

+  _target_dir_name = get_label_info(":$target_name", "dir")
+  output = "${root_out_dir}/lib.java${_target_dir_name}/${target_name}.jar"
+  direct_deps_only = true
+  use_interface_jars = false
+  deps = [
+    ":libjingle_peerconnection_java",

[sakal, 2017/01/18 13:21:44]

I think libjingle_peerconnection_metrics_default_java should be included.

[mbonadei, 2017/01/19 08:30:45]

I see what you mean. I can include it but I have a proposal, let me know what do
you think about that.

libjingle_peerconnection_metrics_default_java seems to required only by
libjingle_peerconnection_android_unittest (it is also a dependency of
AppRTCMobile_javalib but it is not really needed), why are we keeping a separate
target only for one class? Can't we just put the file
"api/org/webrtc/Metrics.java" into the java_files of
libjingle_peerconnection_java and remove the target
libjingle_peerconnection_metrics_default_java?

[sakal, 2017/01/19 09:06:21]

The reason this target exists is to allow clients to provide custom metrics
implementations. Metrics.java relies on using the default metrics_default.cc and
is not compatible with custom implementations. I would expect the kind of
applications that include the libwebrtc.jar to just use the default
implementation though.

[mbonadei, 2017/01/19 21:20:03]

Ok, thanks for the explanation.

+    "//webrtc/base:base_java",
+    "//webrtc/modules/audio_device:audio_device_java",
+  ]
+}
+
 android_library("libjingle_peerconnection_java") {
   java_files = [
     "api/org/webrtc/AudioSource.java",
     "api/org/webrtc/AudioTrack.java",
     "api/org/webrtc/CallSessionFileRotatingLogSink.java",
     "api/org/webrtc/Camera1Capturer.java",
     "api/org/webrtc/Camera1Enumerator.java",
     "api/org/webrtc/Camera1Session.java",
     "api/org/webrtc/Camera2Capturer.java",
     "api/org/webrtc/Camera2Enumerator.java",
@@ skipping 41 matching lines @@
     "api/org/webrtc/VideoFileRenderer.java",
     "api/org/webrtc/VideoRenderer.java",
     "api/org/webrtc/VideoRendererGui.java",
     "api/org/webrtc/VideoSource.java",
     "api/org/webrtc/VideoTrack.java",
     "api/org/webrtc/YuvConverter.java",
   ]
 
   deps = [
     "//webrtc/base:base_java",
+    "//webrtc/modules/audio_device:audio_device_java",
   ]
-
-  srcjar_deps = [ "//webrtc/modules/audio_device:audio_device_java" ]
 }
 
 android_library("libjingle_peerconnection_metrics_default_java") {
   java_files = [ "api/org/webrtc/Metrics.java" ]
 
   deps = [
     "//webrtc/base:base_java",
   ]
 }
 
@@ skipping 31 matching lines @@
       "//third_party/android_support_test_runner:runner_java",
       "//third_party/junit",
       "//webrtc/base:base_java",
       "//webrtc/sdk/android:libjingle_peerconnection_java",
       "//webrtc/sdk/android:libjingle_peerconnection_metrics_default_java",
     ]
 
     shared_libraries = [ "//webrtc/sdk/android:libjingle_peerconnection_so" ]
   }
 }