webrtc/media/engine/webrtcvideoengine2.cc - Issue 2645703003: Stop leaking FlexfecReceiveStream objects after call shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/webrtcvideoengine2.cc

Issue 2645703003: Stop leaking FlexfecReceiveStream objects after call shutdown. (Closed)

Patch Set: Simplified test case. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/media/engine/webrtcvideoengine2.cc

diff --git a/webrtc/media/engine/webrtcvideoengine2.cc b/webrtc/media/engine/webrtcvideoengine2.cc

index b0d3b89b8a2115f4b83b576a2f54e125f9d47c04..4a1d11cdcde7fc01796222595464b8ebd144a07b 100644

--- a/webrtc/media/engine/webrtcvideoengine2.cc

+++ b/webrtc/media/engine/webrtcvideoengine2.cc

@@ -2126,6 +2126,9 @@ WebRtcVideoChannel2::WebRtcVideoReceiveStream::AllocatedDecoder::

}

WebRtcVideoChannel2::WebRtcVideoReceiveStream::~WebRtcVideoReceiveStream() {

+ if (flexfec_stream_) {

+ call_->DestroyFlexfecReceiveStream(flexfec_stream_);

+ }

call_->DestroyVideoReceiveStream(stream_);

ClearDecoders(&allocated_decoders_);

}