Adding full initial version of delay estimation functionality in echo canceller 3

webrtc/modules/audio_processing/aec3/correlator_lag_aggregator.h

Index: webrtc/modules/audio_processing/aec3/correlator_lag_aggregator.h
diff --git a/webrtc/modules/audio_processing/aec3/correlator_lag_aggregator.h b/webrtc/modules/audio_processing/aec3/correlator_lag_aggregator.h
new file mode 100644
index 0000000000000000000000000000000000000000..53ccba83300fb05cf3363e4aa727e2bed189a846
--- /dev/null
+++ b/webrtc/modules/audio_processing/aec3/correlator_lag_aggregator.h
@@ -0,0 +1,46 @@
+/*
+ *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_MODULES_AUDIO_PROCESSING_AEC3_CORRELATOR_LAG_AGGREGATOR_H_
+#define WEBRTC_MODULES_AUDIO_PROCESSING_AEC3_CORRELATOR_LAG_AGGREGATOR_H_
+
+#include <vector>
+
+#include "webrtc/base/constructormagic.h"
+#include "webrtc/base/optional.h"
+#include "webrtc/modules/audio_processing/aec3/correlator.h"

[hlundin-webrtc, 2017/02/01 08:30:01]

Will it be sufficient to fwd declare Correlator::LagEstimate?

[peah-webrtc, 2017/02/02 14:04:45]

No, that does not seem to work. I get the error "forward declaration of struct
cannot have a nested name specifier".

[hlundin-webrtc, 2017/02/06 09:13:18]

Acknowledged.

[peah-webrtc, 2017/02/06 11:25:38]

Acknowledged.

+#include "webrtc/modules/audio_processing/logging/apm_data_dumper.h"

[hlundin-webrtc, 2017/02/01 08:30:01]

Fwd declare.

[peah-webrtc, 2017/02/02 14:04:45]

Done.

+
+namespace webrtc {
+
+// Aggregates lag estimates produced by the Correlator class into a single
+// reliable combined lag estimate.
+class CorrelatorLagAggregator {
+ public:
+  CorrelatorLagAggregator(ApmDataDumper* data_dumper,
+                          size_t num_correlator_lag_estimates);
+  ~CorrelatorLagAggregator();
+
+  // Aggregates the lag estimates and produces an optional combined reliable lag
+  // estimate

[hlundin-webrtc, 2017/02/01 08:30:01]

This is the same comment as above. But without .

[peah-webrtc, 2017/02/02 14:04:45]

Done.

+  rtc::Optional<size_t> Aggregate(
+      rtc::ArrayView<const Correlator::LagEstimate> lag_estimates);
+
+ private:
+  ApmDataDumper* const data_dumper_;
+  std::vector<size_t> lag_updates_in_a_row_;
+  size_t candidate_ = 0;
+  size_t candidate_counter_ = 0;
+
+  RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(CorrelatorLagAggregator);
+};
+}  // namespace webrtc
+
+#endif  // WEBRTC_MODULES_AUDIO_PROCESSING_AEC3_CORRELATOR_LAG_AGGREGATOR_H_