Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Unified Diff: webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller.h

Issue 2643133003: Instantly pass network changes to controllers in audio network adaptor. (Closed)
Patch Set: fixing unittests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller.h
diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller.h b/webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller.h
index bce7f8ff03d76e9aba131f9fb7c556164957cde0..ba0c1c2ab2d09a2c76f568d9d925b2974f3ffefe 100644
--- a/webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller.h
+++ b/webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller.h
@@ -49,8 +49,9 @@ class FrameLengthController final : public Controller {
~FrameLengthController() override;
- void MakeDecision(const NetworkMetrics& metrics,
- AudioNetworkAdaptor::EncoderRuntimeConfig* config) override;
+ void UpdateNetworkMetrics(const NetworkMetrics& network_metrics) override;
+
+ void MakeDecision(AudioNetworkAdaptor::EncoderRuntimeConfig* config) override;
private:
friend class FrameLengthControllerForTest;
@@ -64,11 +65,9 @@ class FrameLengthController final : public Controller {
};
bool FrameLengthIncreasingDecision(
- const NetworkMetrics& metrics,
const AudioNetworkAdaptor::EncoderRuntimeConfig& config) const;
bool FrameLengthDecreasingDecision(
- const NetworkMetrics& metrics,
const AudioNetworkAdaptor::EncoderRuntimeConfig& config) const;
const Config config_;
@@ -77,6 +76,10 @@ class FrameLengthController final : public Controller {
std::map<FrameLengthChange, int> frame_length_change_criteria_;
+ rtc::Optional<int> uplink_bandwidth_bps_;
+
+ rtc::Optional<float> uplink_packet_loss_fraction_;
+
RTC_DISALLOW_COPY_AND_ASSIGN(FrameLengthController);
};

Powered by Google App Engine
This is Rietveld 408576698