webrtc/modules/audio_coding/audio_network_adaptor/dtx_controller_unittest.cc - Issue 2643133003: Instantly pass network changes to controllers in audio network adaptor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/audio_network_adaptor/dtx_controller_unittest.cc

Issue 2643133003: Instantly pass network changes to controllers in audio network adaptor. (Closed)

Patch Set: fixing unittests Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/audio_network_adaptor/dtx_controller.cc ('k') | webrtc/modules/audio_coding/audio_network_adaptor/fec_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/audio_network_adaptor/dtx_controller_unittest.cc

diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/dtx_controller_unittest.cc b/webrtc/modules/audio_coding/audio_network_adaptor/dtx_controller_unittest.cc

index 4eea54e8642fa457675bd47136f8a4e71bac1bd2..7b60e8f433d9958af285c8595306ed1429cf18f5 100644

--- a/webrtc/modules/audio_coding/audio_network_adaptor/dtx_controller_unittest.cc

+++ b/webrtc/modules/audio_coding/audio_network_adaptor/dtx_controller_unittest.cc

@@ -32,10 +32,13 @@ std::unique_ptr<DtxController> CreateController(int initial_dtx_enabled) {

void CheckDecision(DtxController* controller,

const rtc::Optional<int>& uplink_bandwidth_bps,

bool expected_dtx_enabled) {

+ if (uplink_bandwidth_bps) {

+ Controller::NetworkMetrics network_metrics;

+ network_metrics.uplink_bandwidth_bps = uplink_bandwidth_bps;

+ controller->UpdateNetworkMetrics(network_metrics);

+ }

AudioNetworkAdaptor::EncoderRuntimeConfig config;

- Controller::NetworkMetrics metrics;

- metrics.uplink_bandwidth_bps = uplink_bandwidth_bps;

- controller->MakeDecision(metrics, &config);

+ controller->MakeDecision(&config);

EXPECT_EQ(rtc::Optional<bool>(expected_dtx_enabled), config.enable_dtx);

}