webrtc/modules/video_coding/h264_sprop_parameter_sets.cc - Issue 2641463002: Unit test out of band H264 SPS,PPS within RtpStreamReceiver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/h264_sprop_parameter_sets.cc

Issue 2641463002: Unit test out of band H264 SPS,PPS within RtpStreamReceiver. (Closed)

Patch Set: Add bitstream expectations and rebase on https://codereview.webrtc.org/2638933002/ . Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/h264_sprop_parameter_sets.cc

diff --git a/webrtc/modules/video_coding/h264_sprop_parameter_sets.cc b/webrtc/modules/video_coding/h264_sprop_parameter_sets.cc

index d2e37232a8614be285f0f2fae19e45834aa0d3da..ae298a341f3e8e20c7937ac8664ce11b9c779401 100644

--- a/webrtc/modules/video_coding/h264_sprop_parameter_sets.cc

+++ b/webrtc/modules/video_coding/h264_sprop_parameter_sets.cc

@@ -29,6 +29,7 @@ namespace webrtc {

bool H264SpropParameterSets::DecodeSprop(const std::string& sprop) {

size_t separator_pos = sprop.find(',');

+ LOG(LS_INFO) << "Parsing sprop \"" << sprop << "\"";

if ((separator_pos <= 0) || (separator_pos >= sprop.length() - 1)) {

LOG(LS_WARNING) << "Invalid seperator position " << separator_pos << " *"

<< sprop << "*";