Treat all unexpected socket errors as indicating close.

Treat all unexpected socket errors as indicating close.

BUG=webrtc:7016

[nisse-webrtc, 2017-01-19 13:00:38]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 13:00:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[nisse-webrtc, 2017-01-19 13:01:32]

nisse@webrtc.org changed reviewers:
+ henrika@webrtc.org

[nisse-webrtc, 2017-01-19 13:01:34]

Can you give this cl a try to see it it solves the problem?

[henrika_webrtc, 2017-01-19 13:32:31]

Does not work for me:

01-19 14:31:49.512 13336 13367 W libjingle: (physicalsocketserver.cc:721):
Unexpected error from recv : [0x0000000e] Bad address
01-19 14:31:49.531 13336 13367 W libjingle: (physicalsocketserver.cc:721):
Unexpected error from recv : [0x0000000e] Bad address
01-19 14:31:49.552 13336 13367 W libjingle: (physicalsocketserver.cc:721):
Unexpected error from recv : [0x0000000e] Bad address
01-19 14:31:49.575 13336 13367 W libjingle: (physicalsocketserver.cc:721):
Unexpected error from recv : [0x0000000e] Bad address
01-19 14:31:49.598 13336 13367 W libjingle: (physicalsocketserver.cc:721):
Unexpected error from recv : [0x0000000e] Bad address
01-19 14:31:49.614 13336 13367 W libjingle: (physicalsocketserver.cc:721):
Unexpected error from recv : [0x0000000e] Bad address
01-19 14:31:49.638 13336 13367 W libjingle: (physicalsocketserver.cc:721):
Unexpected error from recv : [0x0000000e] Bad address
01-19 14:31:49.651 13336 13367 W libjingle: (physicalsocketserver.cc:721):
Unexpected error from recv : [0x0000000e] Bad address
01-19 14:31:49.674 13336 13367 W libjingle: (physicalsocketserver.cc:721):
Unexpected error from recv : [0x0000000e] Bad address
01-19 14:31:49.692 13336 13367 W libjingle: (physicalsocketserver.cc:721):
Unexpected error from recv : [0x0000000e] Bad address
01-19 14:31:49.712 13336 13367 W libjingle: (physicalsocketserver.cc:721):
Unexpected error from recv : [0x0000000e] Bad address

[commit-bot: I haz the power, 2017-01-19 14:32:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 14:32:07]

Dry run: This issue passed the CQ dry run.

[Taylor Brandstetter, 2017-02-09 08:59:46]

deadbeef@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[Taylor Brandstetter, 2017-02-09 08:59:47]

https://codereview.webrtc.org/2639283004/diff/1/webrtc/base/physicalsocketser...
File webrtc/base/physicalsocketserver.cc (right):

https://codereview.webrtc.org/2639283004/diff/1/webrtc/base/physicalsocketser...
webrtc/base/physicalsocketserver.cc:716: return true;
I don't think this is safe. There are errors besides EWOULDBLOCK on different
platforms that actually are benign blocking errors, in my experience. So the
default should be to assume it's a benign error.