Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: webrtc/modules/video_coding/codecs/test/videoprocessor.cc

Issue 2639203005: Use std::unique_ptr in VideoProcessorIntegrationTest. (Closed)
Patch Set: address comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/video_coding/codecs/test/videoprocessor.cc
diff --git a/webrtc/modules/video_coding/codecs/test/videoprocessor.cc b/webrtc/modules/video_coding/codecs/test/videoprocessor.cc
index 63f0a871503cf700bcf09f7d06425de09215c0d5..ebacf75f7763f7d19bddeb8863fcc05a070ac44a 100644
--- a/webrtc/modules/video_coding/codecs/test/videoprocessor.cc
+++ b/webrtc/modules/video_coding/codecs/test/videoprocessor.cc
@@ -26,6 +26,21 @@
namespace webrtc {
namespace test {
+namespace {
+std::string CodecTypeToString(VideoCodecType codec_type) {
+ switch (codec_type) {
+ case kVideoCodecVP8:
+ return "VP8";
+ case kVideoCodecVP9:
+ return "VP9";
+ case kVideoCodecH264:
+ return "H264";
+ default:
+ RTC_NOTREACHED();
+ return "";
+ }
+}
sprang_webrtc 2017/02/07 09:18:36 Maybe use CodecTypeToPayloadName() from webrtc/com
åsapersson 2017/02/07 09:39:34 Done.
+} // namespace
TestConfig::TestConfig()
: name(""),
@@ -146,10 +161,29 @@ bool VideoProcessorImpl::Init() {
printf(" #CPU cores used : %d\n", nbr_of_cores);
printf(" Total # of frames: %d\n", frame_reader_->NumberOfFrames());
printf(" Codec settings:\n");
- printf(" Start bitrate : %d kbps\n",
+ printf(" Start bitrate : %d kbps\n",
config_.codec_settings->startBitrate);
- printf(" Width : %d\n", config_.codec_settings->width);
- printf(" Height : %d\n", config_.codec_settings->height);
+ printf(" Width : %d\n", config_.codec_settings->width);
+ printf(" Height : %d\n", config_.codec_settings->height);
+ printf(" Codec type : %s\n",
+ CodecTypeToString(config_.codec_settings->codecType).c_str());
+ printf(" Encoder implementation name: %s\n",
+ encoder_->ImplementationName());
+ printf(" Decoder implementation name: %s\n",
+ decoder_->ImplementationName());
+ if (config_.codec_settings->codecType == kVideoCodecVP8) {
+ printf(" Denoising : %d\n",
+ config_.codec_settings->VP8()->denoisingOn);
+ printf(" Error concealment: %d\n",
+ config_.codec_settings->VP8()->errorConcealmentOn);
+ printf(" Frame dropping : %d\n",
+ config_.codec_settings->VP8()->frameDroppingOn);
+ printf(" Resilience : %d\n",
+ config_.codec_settings->VP8()->resilience);
+ } else if (config_.codec_settings->codecType == kVideoCodecVP9) {
+ printf(" Resilience : %d\n",
+ config_.codec_settings->VP9()->resilience);
+ }
}
initialized_ = true;
return true;
« no previous file with comments | « no previous file | webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698