webrtc/video/rtp_stream_receiver.cc - Issue 2638933002: H264SpsPpsTracker.InsertSpsPpsNalus() should accept Nalus with header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/video/rtp_stream_receiver.cc

Issue 2638933002: H264SpsPpsTracker.InsertSpsPpsNalus() should accept Nalus with header. (Closed)

Patch Set: Add failure test cases and cleanup. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/video/rtp_stream_receiver.cc

diff --git a/webrtc/video/rtp_stream_receiver.cc b/webrtc/video/rtp_stream_receiver.cc

index d2360858729993b3432006b746bc0c54516d729b..bca317cf5716d717e51911d8e8dc87240f92778c 100644

--- a/webrtc/video/rtp_stream_receiver.cc

+++ b/webrtc/video/rtp_stream_receiver.cc

@@ -684,7 +684,8 @@ void RtpStreamReceiver::InsertSpsPpsIntoTracker(uint8_t payload_type) {

if (!sprop_decoder.DecodeSprop(sprop_base64_it->second))

return;

- tracker_.InsertSpsPps(sprop_decoder.sps_nalu(), sprop_decoder.pps_nalu());

+ tracker_.InsertSpsPpsNalus(sprop_decoder.sps_nalu(),

+ sprop_decoder.pps_nalu());

}

} // namespace webrtc