Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: webrtc/video/end_to_end_tests.cc

Issue 2638423003: Revert of Make the new jitter buffer the default jitter buffer. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/video_coding/video_receiver.cc ('k') | webrtc/video/receive_statistics_proxy.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include <algorithm> 10 #include <algorithm>
(...skipping 1210 matching lines...) Expand 10 before | Expand all | Expand 10 after
1221 } test(rtp_history_ms); 1221 } test(rtp_history_ms);
1222 1222
1223 RunBaseTest(&test); 1223 RunBaseTest(&test);
1224 } 1224 }
1225 1225
1226 TEST_P(EndToEndTest, ReceivesPliAndRecoversWithNack) { 1226 TEST_P(EndToEndTest, ReceivesPliAndRecoversWithNack) {
1227 ReceivesPliAndRecovers(1000); 1227 ReceivesPliAndRecovers(1000);
1228 } 1228 }
1229 1229
1230 TEST_P(EndToEndTest, ReceivesPliAndRecoversWithoutNack) { 1230 TEST_P(EndToEndTest, ReceivesPliAndRecoversWithoutNack) {
1231 // This test makes no sense for the new video jitter buffer.
1232 if (GetParam() == new_jb_enabled)
1233 return;
1231 ReceivesPliAndRecovers(0); 1234 ReceivesPliAndRecovers(0);
1232 } 1235 }
1233 1236
1234 TEST_P(EndToEndTest, UnknownRtpPacketGivesUnknownSsrcReturnCode) { 1237 TEST_P(EndToEndTest, UnknownRtpPacketGivesUnknownSsrcReturnCode) {
1235 class PacketInputObserver : public PacketReceiver { 1238 class PacketInputObserver : public PacketReceiver {
1236 public: 1239 public:
1237 explicit PacketInputObserver(PacketReceiver* receiver) 1240 explicit PacketInputObserver(PacketReceiver* receiver)
1238 : receiver_(receiver), delivered_packet_(false, false) {} 1241 : receiver_(receiver), delivered_packet_(false, false) {}
1239 1242
1240 bool Wait() { return delivered_packet_.Wait(kDefaultTimeoutMs); } 1243 bool Wait() { return delivered_packet_.Wait(kDefaultTimeoutMs); }
(...skipping 1779 matching lines...) Expand 10 before | Expand all | Expand 10 after
3020 std::map<std::string, bool> send_stats_filled_; 3023 std::map<std::string, bool> send_stats_filled_;
3021 3024
3022 std::vector<uint32_t> expected_receive_ssrcs_; 3025 std::vector<uint32_t> expected_receive_ssrcs_;
3023 std::set<uint32_t> expected_send_ssrcs_; 3026 std::set<uint32_t> expected_send_ssrcs_;
3024 std::string expected_cname_; 3027 std::string expected_cname_;
3025 3028
3026 rtc::Event check_stats_event_; 3029 rtc::Event check_stats_event_;
3027 ReceiveStreamRenderer receive_stream_renderer_; 3030 ReceiveStreamRenderer receive_stream_renderer_;
3028 } test; 3031 } test;
3029 3032
3033 // TODO(philipel): Implement statistics for the new video jitter buffer.
3034 if (GetParam() == new_jb_enabled)
3035 return;
3036
3030 RunBaseTest(&test); 3037 RunBaseTest(&test);
3031 } 3038 }
3032 3039
3033 class RtcpXrObserver : public test::EndToEndTest { 3040 class RtcpXrObserver : public test::EndToEndTest {
3034 public: 3041 public:
3035 RtcpXrObserver(bool enable_rrtr, bool enable_target_bitrate) 3042 RtcpXrObserver(bool enable_rrtr, bool enable_target_bitrate)
3036 : EndToEndTest(test::CallTest::kDefaultTimeoutMs), 3043 : EndToEndTest(test::CallTest::kDefaultTimeoutMs),
3037 enable_rrtr_(enable_rrtr), 3044 enable_rrtr_(enable_rrtr),
3038 enable_target_bitrate_(enable_target_bitrate), 3045 enable_target_bitrate_(enable_target_bitrate),
3039 sent_rtcp_sr_(0), 3046 sent_rtcp_sr_(0),
(...skipping 1080 matching lines...) Expand 10 before | Expand all | Expand 10 after
4120 std::unique_ptr<VideoEncoder> encoder_; 4127 std::unique_ptr<VideoEncoder> encoder_;
4121 std::unique_ptr<VideoDecoder> decoder_; 4128 std::unique_ptr<VideoDecoder> decoder_;
4122 rtc::CriticalSection crit_; 4129 rtc::CriticalSection crit_;
4123 int recorded_frames_ GUARDED_BY(crit_); 4130 int recorded_frames_ GUARDED_BY(crit_);
4124 } test(this); 4131 } test(this);
4125 4132
4126 RunBaseTest(&test); 4133 RunBaseTest(&test);
4127 } 4134 }
4128 4135
4129 } // namespace webrtc 4136 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/video_coding/video_receiver.cc ('k') | webrtc/video/receive_statistics_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698