Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1587)

Unified Diff: webrtc/modules/pacing/alr_detector.cc

Issue 2637783003: Move congestion controller processing to the pacer thread. (Closed)
Patch Set: Reorder calls in CongestionController::Process. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/pacing/alr_detector.cc
diff --git a/webrtc/modules/pacing/alr_detector.cc b/webrtc/modules/pacing/alr_detector.cc
index b31d4482bba37896bb7b0709d7e796d6e8c6eb53..9a917983be20c53169100e7e1001eeeafd8b9997 100644
--- a/webrtc/modules/pacing/alr_detector.cc
+++ b/webrtc/modules/pacing/alr_detector.cc
@@ -36,6 +36,10 @@ AlrDetector::AlrDetector()
AlrDetector::~AlrDetector() {}
void AlrDetector::OnBytesSent(size_t bytes_sent, int64_t now_ms) {
+ // TODO(nisse): It's unclear what guarantees there are that this
+ // function isn't called before SetEstimatedBitrate. Document that
+ // guarantee, if it exists. Or else, remove the DCHECK and tolerate
+ // that current estimate is zero, e.g., by just returning false.
RTC_DCHECK(estimated_bitrate_bps_);
rate_.Update(bytes_sent, now_ms);
« no previous file with comments | « webrtc/modules/congestion_controller/congestion_controller.cc ('k') | webrtc/modules/pacing/paced_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698