Move congestion controller processing to the pacer thread.

webrtc/modules/congestion_controller/congestion_controller.cc

Index: webrtc/modules/congestion_controller/congestion_controller.cc
diff --git a/webrtc/modules/congestion_controller/congestion_controller.cc b/webrtc/modules/congestion_controller/congestion_controller.cc
index 94b3d8c6da98bbaee3a070e8e9f2421044a758b9..c970ffe9c0ec1b7f0c1b570fb8ba07a538a47229 100644
--- a/webrtc/modules/congestion_controller/congestion_controller.cc
+++ b/webrtc/modules/congestion_controller/congestion_controller.cc
@@ -327,14 +327,18 @@ void CongestionController::OnRttUpdate(int64_t avg_rtt_ms, int64_t max_rtt_ms) {
 }
 
 int64_t CongestionController::TimeUntilNextProcess() {
-  return std::min(bitrate_controller_->TimeUntilNextProcess(),
-                  remote_bitrate_estimator_->TimeUntilNextProcess());
+  return std::min({bitrate_controller_->TimeUntilNextProcess(),
+                   remote_bitrate_estimator_->TimeUntilNextProcess(),
+                   pacer_->TimeUntilNextProcess(),
+                   remote_estimator_proxy_.TimeUntilNextProcess()});
 }
 
 void CongestionController::Process() {
   bitrate_controller_->Process();
   remote_bitrate_estimator_->Process();
   probe_controller_->Process();
+  pacer_->Process();
+  remote_estimator_proxy_.Process();
   MaybeTriggerOnNetworkChanged();

[danilchap, 2017/01/16 17:09:39]

look like it is this function that SetEstimatedBitrate.
Does it make sense to put it before pacer_->Process(); // With a comment why.

[nisse-webrtc, 2017/01/17 07:42:39]

Reorder isn't enough, first call to MaybeTriggerOnNetworkChanged gets
|estimate_changed| == false, and hence doesn't call SetEstimatedBitrate.

So PacedSender::Process still needs the change to make calling
alr_detector_->OnBytesSent conditional on bytes_sent > 0, otherwise it crashes
in the AlrDetector DCHECK.

I'd be happy to reorder the calls anyway you like (I really don't know  if some
order makes more sense than any  other order), but it seems it doesn't by itself
solve the AlrDetector call order requirements.

[stefan-webrtc, 2017/01/17 07:59:54]

It might be a good idea to call MaybeTriggerOnNetworkChanged() before
probe_controller_->Process(), pacer_->Process() and
remote_estimator_proxy_.Process(), simply because they use the result of
MaybeTriggerOnNetworkChanged().

[nisse-webrtc, 2017/01/17 08:39:35]

Done.

 }