Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: webrtc/modules/pacing/alr_detector.cc

Issue 2637783003: Move congestion controller processing to the pacer thread. (Closed)
Patch Set: Fixed method call order for AlrDetector. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/pacing/alr_detector.cc
diff --git a/webrtc/modules/pacing/alr_detector.cc b/webrtc/modules/pacing/alr_detector.cc
index b31d4482bba37896bb7b0709d7e796d6e8c6eb53..997fd130985f4d2f6a608367dd7801f78fec932f 100644
--- a/webrtc/modules/pacing/alr_detector.cc
+++ b/webrtc/modules/pacing/alr_detector.cc
@@ -36,6 +36,8 @@ AlrDetector::AlrDetector()
AlrDetector::~AlrDetector() {}
void AlrDetector::OnBytesSent(size_t bytes_sent, int64_t now_ms) {
+ // TODO(nisse): It's unclear what guarantees there are that this
+ // function isn't called before SetEstimatedBitrate.
stefan-webrtc 2017/01/16 15:42:46 I guess the guarantee is here in form of a DCHECK.
nisse-webrtc 2017/01/16 16:14:03 Problem was, this thread reorg made this check cra
RTC_DCHECK(estimated_bitrate_bps_);
rate_.Update(bytes_sent, now_ms);

Powered by Google App Engine
This is Rietveld 408576698