Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_sender.cc

Issue 2637203002: Avoid multiple calls to webrtc::field_trial::FindFullName in RTPSender (Closed)
Patch Set: Trying again... Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_sender.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtp_sender.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender.cc b/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
index ae491209b7f22edf1ff3d063a66ded37dfeff200..add7c21e9be22e109c15227de2b7ee0ac4336c7f 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
@@ -123,7 +123,10 @@ RTPSender::RTPSender(
rtx_(kRtxOff),
rtp_overhead_bytes_per_packet_(0),
retransmission_rate_limiter_(retransmission_rate_limiter),
- overhead_observer_(overhead_observer) {
+ overhead_observer_(overhead_observer),
+ send_side_bwe_with_overhead_(
+ webrtc::field_trial::FindFullName(
+ "WebRTC-SendSideBwe-WithOverhead") == "Enabled") {
ssrc_ = ssrc_db_->CreateSSRC();
RTC_DCHECK(ssrc_ != 0);
ssrc_rtx_ = ssrc_db_->CreateSSRC();
@@ -1256,8 +1259,7 @@ void RTPSender::AddPacketToTransportFeedback(uint16_t packet_id,
const RtpPacketToSend& packet,
int probe_cluster_id) {
size_t packet_size = packet.payload_size() + packet.padding_size();
- if (webrtc::field_trial::FindFullName("WebRTC-SendSideBwe-WithOverhead") ==
- "Enabled") {
+ if (send_side_bwe_with_overhead_) {
packet_size = packet.size();
}
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_sender.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698