Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: webrtc/api/video/video_frame.h

Issue 2633493002: Delete VideoFrame::set_render_time_ms. (Closed)
Patch Set: Add deprecation comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/video/video_frame.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/video/video_frame.h
diff --git a/webrtc/api/video/video_frame.h b/webrtc/api/video/video_frame.h
index f960fa92008eee8abca1a004ee58e8251f5c4f90..5c57213f018aabbf28549d3a66031a3111778822 100644
--- a/webrtc/api/video/video_frame.h
+++ b/webrtc/api/video/video_frame.h
@@ -71,9 +71,11 @@ class VideoFrame {
uint32_t transport_frame_id() const { return timestamp(); }
// Set capture ntp time in milliseconds.
+ // TODO(nisse): Deprecated. Migrate all users to timestamp_us().
stefan-webrtc 2017/01/25 15:38:51 May want to use RTC_DEPRECATED?
nisse-webrtc 2017/01/25 15:52:11 Due to the widespread use of the -Werror option (t
void set_ntp_time_ms(int64_t ntp_time_ms) { ntp_time_ms_ = ntp_time_ms; }
// Get capture ntp time in milliseconds.
+ // TODO(nisse): Deprecated. Migrate all users to timestamp_us().
int64_t ntp_time_ms() const { return ntp_time_ms_; }
// Naming convention for Coordination of Video Orientation. Please see
@@ -89,10 +91,8 @@ class VideoFrame {
VideoRotation rotation() const { return rotation_; }
void set_rotation(VideoRotation rotation) { rotation_ = rotation; }
- // Set render time in milliseconds.
- void set_render_time_ms(int64_t render_time_ms);
-
// Get render time in milliseconds.
+ // TODO(nisse): Deprecated. Migrate all users to timestamp_us().
int64_t render_time_ms() const;
// Return the underlying buffer. Never nullptr for a properly
« no previous file with comments | « no previous file | webrtc/api/video/video_frame.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698