webrtc/modules/video_coding/generic_decoder.cc - Issue 2633493002: Delete VideoFrame::set_render_time_ms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/generic_decoder.cc

Issue 2633493002: Delete VideoFrame::set_render_time_ms. (Closed)

Patch Set: Keep timestamp override in ViEEncoder::OnFrame for now. Hopefully fixes tests. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/generic_decoder.cc

diff --git a/webrtc/modules/video_coding/generic_decoder.cc b/webrtc/modules/video_coding/generic_decoder.cc

index b95571b8f73793718d318eedc82fff249e9a9f17..b1059e8a1b6997a378b85400d57860a5b7cdf878 100644

--- a/webrtc/modules/video_coding/generic_decoder.cc

+++ b/webrtc/modules/video_coding/generic_decoder.cc

@@ -74,7 +74,8 @@ int32_t VCMDecodedFrameCallback::Decoded(VideoFrame& decodedImage,

_timing->StopDecodeTimer(decodedImage.timestamp(), decode_time_ms, now_ms,

frameInfo->renderTimeMs);

- decodedImage.set_render_time_ms(frameInfo->renderTimeMs);

+ decodedImage.set_timestamp_us(

+ frameInfo->renderTimeMs * rtc::kNumMicrosecsPerMillisec);

decodedImage.set_rotation(frameInfo->rotation);

// TODO(sakal): Investigate why callback is NULL sometimes and replace if

// statement with a DCHECK.