Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: webrtc/tools/test_stubbed_loopback_video.py

Issue 2632323003: Script to start stubbed loopback video test with Espresso (Closed)
Patch Set: Using os.path.join for path concatenation instead of + Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/tools/test_stubbed_loopback_video.py
diff --git a/webrtc/tools/test_stubbed_loopback_video.py b/webrtc/tools/test_stubbed_loopback_video.py
new file mode 100755
index 0000000000000000000000000000000000000000..790df39bf94bd610a7cd72e1d89f48cf2341b8d3
--- /dev/null
+++ b/webrtc/tools/test_stubbed_loopback_video.py
@@ -0,0 +1,114 @@
+#!/usr/bin/env python
+# Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+#
+# Use of this source code is governed by a BSD-style license
+# that can be found in the LICENSE file in the root of the source
+# tree. An additional intellectual property rights grant can be found
+# in the file PATENTS. All contributing project authors may
+# be found in the AUTHORS file in the root of the source tree.
+
+import argparse
kjellander_webrtc 2017/01/19 13:55:34 Please add a module docstring that briefly describ
mandermo 2017/01/19 16:46:42 Have added a comment now. Anything other format or
+import os
+import shutil
+import subprocess
+import sys
+import tempfile
+
+SCRIPT_DIR = os.path.dirname(os.path.abspath(__file__))
+
+WEBRTC_DIR = os.path.normpath(os.path.join(SCRIPT_DIR, '../../'))
kjellander_webrtc 2017/01/19 13:55:34 Call this SRC_DIR to avoid confusion (there's a we
kjellander_webrtc 2017/01/19 13:55:34 The way to write this is: os.path.normpath(os.path
mandermo 2017/01/19 16:46:42 Done.
mandermo 2017/01/19 16:46:42 Done.
+
+def _ParseArgs():
+ parser = argparse.ArgumentParser(description='Start loopback video analysis')
+ parser.add_argument('--source_dir',
kjellander_webrtc 2017/01/19 13:55:34 This flag doesn't seem to be needed if we just use
mandermo 2017/01/19 16:46:42 This is an optional argument. It was useful when I
kjellander_webrtc 2017/01/20 08:18:56 As it's now defaulting to the SRC_DIR, it's fine t
mandermo 2017/01/23 09:09:30 Done. Added "." to the end of the help texts also.
+ default=WEBRTC_DIR, help='The path to the WebRTC source directory')
+ parser.add_argument('build_dir_android',
+ help='The path to the build directory for Android')
+ parser.add_argument('--build_dir_x86',
+ help='The path to the build directory for building locally')
+ parser.add_argument('--temp_dir',
+ help='A temporary directory to put the output')
+
+ args = parser.parse_args()
kjellander_webrtc 2017/01/19 13:55:34 Please add parser.error() messages to error out in
mandermo 2017/01/19 16:46:42 Why should they all be mandatory? Only build_dir_a
+ return args
+
kjellander_webrtc 2017/01/19 13:55:35 +1 blank line before top-level functions.
mandermo 2017/01/19 16:46:42 Done.
+def main():
+ args = _ParseArgs()
+
+ source_dir = args.source_dir
+ build_dir_android = args.build_dir_android
+ build_dir_x86 = args.build_dir_x86
+ temp_dir = args.temp_dir
+ if not temp_dir:
+ temp_dir = tempfile.mkdtemp()
+ else:
+ if not os.path.exists(temp_dir):
+ os.makedirs(temp_dir)
+
+ if not build_dir_x86:
+ build_dir_x86 = os.path.join(temp_dir, 'LocalBuild')
+ subprocess.check_call(['gn', 'gen', build_dir_x86])
+ subprocess.check_call(['ninja', '-C', build_dir_x86, 'frame_analyzer'])
+
+ # Download ffmpeg and zxing.
+ download_script = os.path.join(source_dir,
kjellander_webrtc 2017/01/19 13:55:35 Please introduce a constant at the top of the file
mandermo 2017/01/19 16:46:42 Have introduced a local variable toolchain_dir. If
kjellander_webrtc 2017/01/20 08:18:56 This is fine.
+ 'tools-webrtc/video_quality_toolchain/download.py')
kjellander_webrtc 2017/01/19 13:55:35 Avoid all / and just use multiple string arguments
mandermo 2017/01/19 16:46:42 Done.
+ subprocess.check_call([download_script])
+
+ # Run the Espresso code.
+ espresso_target = os.path.join(build_dir_android,
+ 'bin/run_AppRTCMobileTestStubbedVideoIO')
+ subprocess.check_call([espresso_target])
+
+ # Pull the output video.
+ test_video = os.path.join(temp_dir, 'test_video.y4m')
+ subprocess.check_call(['adb', 'pull', '/sdcard/output.y4m', test_video])
kjellander_webrtc 2017/01/19 13:55:35 Please pass the filename (output.y4m) as a flag, w
mandermo 2017/01/19 16:46:42 As a flag to the script? This path is already hard
kjellander_webrtc 2017/01/20 08:18:56 Argh, you're right. I forgot about that. Hopefully
+
+ test_video_yuv = os.path.join(temp_dir, 'test_video.yuv')
+
+ ffmpeg_path = os.path.join(source_dir,
+ 'tools-webrtc/video_quality_toolchain/linux/ffmpeg')
+
+ def convert_video(input_video, output_video):
+ subprocess.check_call([ffmpeg_path, '-y', '-i', input_video, output_video])
+
+ # Convert the test video.
kjellander_webrtc 2017/01/19 13:55:35 drop this comment, it doesn't add any value.
mandermo 2017/01/19 16:46:42 Done.
+ convert_video(test_video, test_video_yuv)
+
+ reference_video = os.path.join(source_dir,
+ 'resources/reference_video_640x360_30fps.y4m')
kjellander_webrtc 2017/01/19 13:55:35 Please pass this string as a flag instead of hardc
mandermo 2017/01/19 16:46:42 As flag to this script? Can be good with flexibil
kjellander_webrtc 2017/01/20 08:18:56 You're right, my bad.
+
+ reference_video_yuv = os.path.join(temp_dir,
+ 'reference_video_640x360_30fps.yuv')
+
+ # Convert the reference video.
kjellander_webrtc 2017/01/19 13:55:35 This comment doesn't tell anything the code isn't.
mandermo 2017/01/19 16:46:42 Done.
+ convert_video(reference_video, reference_video_yuv)
+
+ # Run compare script.
+ compare_script = os.path.join(source_dir, 'webrtc/tools/compare_videos.py')
+ zxing_path = os.path.join(source_dir,
+ 'tools-webrtc/video_quality_toolchain/linux/zxing')
+
+ # The frame_analyzer binary should be built for local computer and not for
+ # Android
+ frame_analyzer = os.path.join(build_dir_x86, 'frame_analyzer')
+
+ frame_width = 640
+ frame_height = 360
+
+ stats_file_ref = os.path.join(temp_dir, 'stats_ref.txt')
+ stats_file_test = os.path.join(temp_dir, 'stats_test.txt')
+
+ subprocess.check_call([
+ compare_script, '--ref_video', reference_video_yuv,
+ '--test_video', test_video_yuv, '--yuv_frame_width', str(frame_width),
+ '--yuv_frame_height', str(frame_height),
+ '--stats_file_ref', stats_file_ref,
+ '--stats_file_test', stats_file_test, '--frame_analyzer', frame_analyzer,
+ '--ffmpeg_path', ffmpeg_path, '--zxing_path', zxing_path])
+
+ shutil.rmtree(temp_dir)
+
kjellander_webrtc 2017/01/19 13:55:34 +1 blank line before top-level functions and state
mandermo 2017/01/19 16:46:42 Done.
+if __name__ == '__main__':
+ sys.exit(main())
+
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698