Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: webrtc/api/statscollector.cc

Issue 2632243002: Add missing if-clause for residual_echo_likelihood_recent_max (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 report->AddInt(i.name, i.value); 121 report->AddInt(i.name, i.value);
122 } 122 }
123 } 123 }
124 // These can take on valid negative values. 124 // These can take on valid negative values.
125 report->AddInt(StatsReport::kStatsValueNameEchoReturnLoss, echo_return_loss); 125 report->AddInt(StatsReport::kStatsValueNameEchoReturnLoss, echo_return_loss);
126 report->AddInt(StatsReport::kStatsValueNameEchoReturnLossEnhancement, 126 report->AddInt(StatsReport::kStatsValueNameEchoReturnLossEnhancement,
127 echo_return_loss_enhancement); 127 echo_return_loss_enhancement);
128 if (residual_echo_likelihood >= 0.0f) { 128 if (residual_echo_likelihood >= 0.0f) {
129 report->AddFloat(StatsReport::kStatsValueNameResidualEchoLikelihood, 129 report->AddFloat(StatsReport::kStatsValueNameResidualEchoLikelihood,
130 residual_echo_likelihood); 130 residual_echo_likelihood);
131 }
132 if (residual_echo_likelihood_recent_max >= 0.0f) {
131 report->AddFloat( 133 report->AddFloat(
132 StatsReport::kStatsValueNameResidualEchoLikelihoodRecentMax, 134 StatsReport::kStatsValueNameResidualEchoLikelihoodRecentMax,
133 residual_echo_likelihood_recent_max); 135 residual_echo_likelihood_recent_max);
134 } 136 }
135 } 137 }
136 138
137 void ExtractStats(const cricket::VoiceReceiverInfo& info, StatsReport* report) { 139 void ExtractStats(const cricket::VoiceReceiverInfo& info, StatsReport* report) {
138 ExtractCommonReceiveProperties(info, report); 140 ExtractCommonReceiveProperties(info, report);
139 const FloatForAdd floats[] = { 141 const FloatForAdd floats[] = {
140 { StatsReport::kStatsValueNameExpandRate, info.expand_rate }, 142 { StatsReport::kStatsValueNameExpandRate, info.expand_rate },
(...skipping 842 matching lines...) Expand 10 before | Expand all | Expand 10 after
983 StatsReport* report = entry.second; 985 StatsReport* report = entry.second;
984 report->set_timestamp(stats_gathering_started_); 986 report->set_timestamp(stats_gathering_started_);
985 } 987 }
986 } 988 }
987 989
988 void StatsCollector::ClearUpdateStatsCacheForTest() { 990 void StatsCollector::ClearUpdateStatsCacheForTest() {
989 stats_gathering_started_ = 0; 991 stats_gathering_started_ = 0;
990 } 992 }
991 993
992 } // namespace webrtc 994 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698