Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: webrtc/api/peerconnectionfactory_unittest.cc

Issue 2632203003: Delete deprecated PeerConnection methods, and corresponding using declarations. (Closed)
Patch Set: Make two additional methods pure virtual. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/peerconnectionfactory_unittest.cc
diff --git a/webrtc/api/peerconnectionfactory_unittest.cc b/webrtc/api/peerconnectionfactory_unittest.cc
index 8b5b335f93a32c70bf7fc56fb8f310abf28304f1..7b8034f40e82b17fb8108f2fe739db77b2acb229 100644
--- a/webrtc/api/peerconnectionfactory_unittest.cc
+++ b/webrtc/api/peerconnectionfactory_unittest.cc
@@ -63,13 +63,6 @@ static const char kTurnIceServerWithIPv6Address[] =
class NullPeerConnectionObserver : public PeerConnectionObserver {
public:
- // We need these using declarations because there are two versions of each of
- // the below methods and we only override one of them.
- // TODO(deadbeef): Remove once there's only one version of the methods.
- using PeerConnectionObserver::OnAddStream;
- using PeerConnectionObserver::OnRemoveStream;
- using PeerConnectionObserver::OnDataChannel;
-
virtual ~NullPeerConnectionObserver() = default;
virtual void OnMessage(const std::string& msg) {}
virtual void OnSignalingMessage(const std::string& msg) {}

Powered by Google App Engine
This is Rietveld 408576698