Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Side by Side Diff: webrtc/sdk/android/src/jni/peerconnection_jni.cc

Issue 2632203003: Delete deprecated PeerConnection methods, and corresponding using declarations. (Closed)
Patch Set: Rebased. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/pc/test/peerconnectiontestwrapper.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 return GetStaticObjectField(jni, j_media_type_class, j_media_type_fid); 199 return GetStaticObjectField(jni, j_media_type_class, j_media_type_fid);
200 } 200 }
201 201
202 class ConstraintsWrapper; 202 class ConstraintsWrapper;
203 203
204 // Adapter between the C++ PeerConnectionObserver interface and the Java 204 // Adapter between the C++ PeerConnectionObserver interface and the Java
205 // PeerConnection.Observer interface. Wraps an instance of the Java interface 205 // PeerConnection.Observer interface. Wraps an instance of the Java interface
206 // and dispatches C++ callbacks to Java. 206 // and dispatches C++ callbacks to Java.
207 class PCOJava : public PeerConnectionObserver { 207 class PCOJava : public PeerConnectionObserver {
208 public: 208 public:
209 // We need these using declarations because there are two versions of each of
210 // the below methods and we only override one of them.
211 // TODO(deadbeef): Remove once there's only one version of the methods.
212 using PeerConnectionObserver::OnAddStream;
213 using PeerConnectionObserver::OnRemoveStream;
214 using PeerConnectionObserver::OnDataChannel;
215
216 PCOJava(JNIEnv* jni, jobject j_observer) 209 PCOJava(JNIEnv* jni, jobject j_observer)
217 : j_observer_global_(jni, j_observer), 210 : j_observer_global_(jni, j_observer),
218 j_observer_class_(jni, GetObjectClass(jni, *j_observer_global_)), 211 j_observer_class_(jni, GetObjectClass(jni, *j_observer_global_)),
219 j_media_stream_class_(jni, FindClass(jni, "org/webrtc/MediaStream")), 212 j_media_stream_class_(jni, FindClass(jni, "org/webrtc/MediaStream")),
220 j_media_stream_ctor_( 213 j_media_stream_ctor_(
221 GetMethodID(jni, *j_media_stream_class_, "<init>", "(J)V")), 214 GetMethodID(jni, *j_media_stream_class_, "<init>", "(J)V")),
222 j_audio_track_class_(jni, FindClass(jni, "org/webrtc/AudioTrack")), 215 j_audio_track_class_(jni, FindClass(jni, "org/webrtc/AudioTrack")),
223 j_audio_track_ctor_( 216 j_audio_track_ctor_(
224 GetMethodID(jni, *j_audio_track_class_, "<init>", "(J)V")), 217 GetMethodID(jni, *j_audio_track_class_, "<init>", "(J)V")),
225 j_video_track_class_(jni, FindClass(jni, "org/webrtc/VideoTrack")), 218 j_video_track_class_(jni, FindClass(jni, "org/webrtc/VideoTrack")),
(...skipping 2508 matching lines...) Expand 10 before | Expand all | Expand 10 after
2734 return reinterpret_cast<DtmfSenderInterface*>(j_dtmf_sender_pointer) 2727 return reinterpret_cast<DtmfSenderInterface*>(j_dtmf_sender_pointer)
2735 ->inter_tone_gap(); 2728 ->inter_tone_gap();
2736 } 2729 }
2737 2730
2738 JOW(void, DtmfSender_free) 2731 JOW(void, DtmfSender_free)
2739 (JNIEnv* jni, jclass, jlong j_dtmf_sender_pointer) { 2732 (JNIEnv* jni, jclass, jlong j_dtmf_sender_pointer) {
2740 reinterpret_cast<DtmfSenderInterface*>(j_dtmf_sender_pointer)->Release(); 2733 reinterpret_cast<DtmfSenderInterface*>(j_dtmf_sender_pointer)->Release();
2741 } 2734 }
2742 2735
2743 } // namespace webrtc_jni 2736 } // namespace webrtc_jni
OLDNEW
« no previous file with comments | « webrtc/pc/test/peerconnectiontestwrapper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698