Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: webrtc/modules/media_file/BUILD.gn

Issue 2629923002: GN: Refactor modules_unittests to eliminate package boundary violations. (Closed)
Patch Set: Addressing comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/desktop_capture/BUILD.gn ('k') | webrtc/modules/pacing/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/media_file/BUILD.gn
diff --git a/webrtc/modules/media_file/BUILD.gn b/webrtc/modules/media_file/BUILD.gn
index f4e93c9034909ed87ec358b2aa4032ca1785b325..8003cd8160f0425e6b5c7fe2e3e671a7247020f5 100644
--- a/webrtc/modules/media_file/BUILD.gn
+++ b/webrtc/modules/media_file/BUILD.gn
@@ -39,3 +39,27 @@ rtc_static_library("media_file") {
"../../system_wrappers",
]
}
+
+if (rtc_include_tests) {
+ rtc_source_set("media_file_unittests") {
+ testonly = true
+ sources = [
+ "media_file_unittest.cc",
+ ]
+ deps = [
+ ":media_file",
+ "../../system_wrappers:system_wrappers",
+ "../../test:test_support",
+ ]
+ if (is_win) {
+ cflags = [
+ # TODO(kjellander): bugs.webrtc.org/261: Fix this warning.
+ "/wd4373", # virtual function override.
+ ]
+ }
+ if (!build_with_chromium && is_clang) {
+ # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
+ suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+ }
+ }
+}
« no previous file with comments | « webrtc/modules/desktop_capture/BUILD.gn ('k') | webrtc/modules/pacing/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698