webrtc/common_audio/BUILD.gn - Issue 2629923002: GN: Refactor modules_unittests to eliminate package boundary violations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/common_audio/BUILD.gn

Issue 2629923002: GN: Refactor modules_unittests to eliminate package boundary violations. (Closed)

Patch Set: Fix iOS issues Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/common_audio/BUILD.gn

diff --git a/webrtc/common_audio/BUILD.gn b/webrtc/common_audio/BUILD.gn

index 2d46f67ef2011b7719c77e7e86b90f0b29c85eef..7a4ac25fee9b9f75fd63b2ffedd60bf01dff3ef8 100644

--- a/webrtc/common_audio/BUILD.gn

+++ b/webrtc/common_audio/BUILD.gn

@@ -101,7 +101,6 @@ rtc_static_library("common_audio") {

}

rtc_source_set("common_audio_c") {

- visibility = [ ":*" ] # Only targets in this file can depend on this.

kjellander_webrtc 2017/01/19 08:10:03 Do we need to relax this? See comment in webrtc/mo

ehmaldonado_webrtc 2017/01/19 14:34:27 Done.

sources = [

"fft4g.c",

"fft4g.h",