GN: Refactor modules_unittests to eliminate package boundary violations.

webrtc/common_audio/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("//build/config/arm.gni")
 import("../build/webrtc.gni")
@@ skipping 83 matching lines @@
     # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
     suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
   }
 
   if (current_cpu == "x86" || current_cpu == "x64") {
     deps += [ ":common_audio_sse2" ]
   }
 }
 
 rtc_source_set("common_audio_c") {
-  visibility = [ ":*" ]  # Only targets in this file can depend on this.

[kjellander_webrtc, 2017/01/19 08:10:03]

Do we need to relax this? See comment in webrtc/modules/audio_coding/BUILD.gn

[ehmaldonado_webrtc, 2017/01/19 14:34:27]

Done.

   sources = [
     "fft4g.c",
     "fft4g.h",
     "ring_buffer.c",
     "ring_buffer.h",
     "signal_processing/auto_corr_to_refl_coef.c",
     "signal_processing/auto_correlation.c",
     "signal_processing/complex_fft_tables.h",
     "signal_processing/copy_set_operations.c",
     "signal_processing/cross_correlation.c",
@@ skipping 225 matching lines @@
       "//testing/gtest",
     ]
 
     if (is_android) {
       deps += [ "//testing/android/native_test:native_test_support" ]
 
       shard_timeout = 900
     }
   }
 }