First-order-FEC recoverability calculation

webrtc/test/fuzzers/transport_feedback_packet_loss_tracker_fuzzer.cc

 /*
  *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include <algorithm>
 
 #include "webrtc/base/array_view.h"
 #include "webrtc/modules/rtp_rtcp/source/byte_io.h"
 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
 #include "webrtc/voice_engine/transport_feedback_packet_loss_tracker.h"
 
 namespace webrtc {
 
 namespace {
 
+template <typename T>
+T FuzzInput(const uint8_t*& data, size_t& size) {

[minyue-webrtc, 2017/01/25 09:38:45]

const uint8_t*& -> uint8_t const** 

size_t& -> size_t*

[elad.alon_webrtc.org, 2017/01/25 12:47:54]

For the future instances - is the guideline "const reference for input, pointer
for output"? Something else, perhaps?

[minyue-webrtc, 2017/01/25 13:54:56]

Rather simple: see
https://google.github.io/styleguide/cppguide.html#Reference_Arguments

+  RTC_CHECK(size >= sizeof(T));
+  T rc = ByteReader<T>::ReadBigEndian(data);
+  data += sizeof(T);
+  size -= sizeof(T);
+  return rc;
+}
+
 class TransportFeedbackGenerator {
  public:
   explicit TransportFeedbackGenerator(rtc::ArrayView<const uint8_t> data)
       : data_(data), ended_(false), data_idx_(0) {}
 
   void GetNextTransportFeedback(rtcp::TransportFeedback* feedback) {
     uint16_t base_seq_num = 0;
     if (!ReadData<uint16_t>(&base_seq_num)) {
       return;
     }
@@ skipping 42 matching lines @@
   }
 
   const rtc::ArrayView<const uint8_t> data_;
   bool ended_;
   size_t data_idx_;
 };
 
 }  // namespace
 
 void FuzzOneInput(const uint8_t* data, size_t size) {
-  if (size < sizeof(uint32_t)) {
+  if (size < 3 * sizeof(uint16_t)) {
     return;
   }
   constexpr size_t kSeqNumHalf = 0x8000u;
-  const size_t window_size_1 = std::min<size_t>(
+
+  // Produce min-window, max-window and min_pairs_num_for_rplr, such that:
+  // a. min <= max <= kSeqNumHalf
+  // b. 1 <= min_pairs_num_for_rplr <= max - 1 (fencepost)
+  // Because of /b/, both min and max can't be below 2.
+
+  const size_t window_size_1 = std::min(
       kSeqNumHalf,
-      std::max<uint16_t>(1, ByteReader<uint16_t>::ReadBigEndian(data)));
-  data += sizeof(uint16_t);
-  const size_t window_size_2 = std::min<size_t>(
+      static_cast<size_t>(std::max(static_cast<uint16_t>(2),

[minyue-webrtc, 2017/01/25 09:38:45]

use std::min<size_t> and std::max<uint16_t> to avoid static cast

[elad.alon_webrtc.org, 2017/01/25 12:47:54]

Done.

+                                   FuzzInput<uint16_t>(data, size))));
+  const size_t window_size_2 = std::min(
       kSeqNumHalf,
-      std::max<uint16_t>(1, ByteReader<uint16_t>::ReadBigEndian(data)));
-  data += sizeof(uint16_t);
-  size -= 2 * sizeof(uint16_t);
+      static_cast<size_t>(std::max(static_cast<uint16_t>(2),
+                                   FuzzInput<uint16_t>(data, size))));
+  const size_t min_window_size = std::min(window_size_1, window_size_2);
+  const size_t max_window_size = std::max(window_size_1, window_size_2);
+  const size_t min_pairs_num_for_rplr = std::min(
+      max_window_size - 1,
+      static_cast<size_t>(std::max(static_cast<uint16_t>(1),

[minyue-webrtc, 2017/01/25 09:38:45]

use max<uint16_t> and min<size_t>

[elad.alon_webrtc.org, 2017/01/25 12:47:54]

Done.

+                                   FuzzInput<uint16_t>(data, size))));
 
   TransportFeedbackPacketLossTracker tracker(
-      std::min(window_size_1, window_size_2),
-      std::max(window_size_1, window_size_2));
+      min_window_size, max_window_size, min_pairs_num_for_rplr);
   TransportFeedbackGenerator feedback_generator(
       rtc::ArrayView<const uint8_t>(data, size));
   while (!feedback_generator.ended()) {
     rtcp::TransportFeedback feedback;
     feedback_generator.GetNextTransportFeedback(&feedback);
     tracker.OnReceivedTransportFeedback(feedback);
     tracker.Validate();
   }
 }
 
 }  // namespace webrtc