tools-webrtc/testdata/expected_stderr - Issue 2629723004: Add presubmit check to prevent package boundary violations.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools-webrtc/testdata/expected_stderr

Issue 2629723004: Add presubmit check to prevent package boundary violations. (Closed)

Patch Set: Addressed comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 testdata/subdir/BUILD.gn:21 in target 'package_boundary_violation':
	kjellander_webrtc 2017/01/24 09:33:19 I think it's better to write more fine-grained tes I think it's better to write more fine-grained test cases so we don't need to resort to just comparing stdout/stderr. When a test fails it's likely going to be a harder-to-read failure message with this approach.
	2 Source file 'subdir2/dummy4.cc'

	3 crosses boundary of package 'subdir2'.

	4

	5 testdata/subdir/BUILD.gn:22 in target 'package_boundary_violation':

	6 Source file 'subdir2/dummy4.h'

	7 crosses boundary of package 'subdir2'.

	8

	9 testdata/subdir/BUILD.gn:34 in target 'package_boundary_violation_unittests':

	10 Source file 'subdir2/dummy3_unittest.cc'

	11 crosses boundary of package 'subdir2'.

	12

OLD	NEW