Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(715)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: tools-webrtc/testdata/BUILD.gn
Issue
2629723004
:
Add presubmit check to prevent package boundary violations. (Closed)
Patch Set: Add tests.
Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
PRESUBMIT.py
tools-webrtc/PRESUBMIT.py
tools-webrtc/check_package_boundaries.py
tools-webrtc/check_package_boundaries_test.py
tools-webrtc/testdata/BUILD.gn
tools-webrtc/testdata/dummy.cc
tools-webrtc/testdata/expected_stderr
tools-webrtc/testdata/expected_stdout
tools-webrtc/testdata/subdir/BUILD.gn
tools-webrtc/testdata/subdir/dummy2.cc
tools-webrtc/testdata/subdir/subdir2/BUILD.gn
tools-webrtc/testdata/subdir/subdir2/dummy3.h
tools-webrtc/testdata/subdir/subdir2/dummy3.cc
tools-webrtc/testdata/subdir/subdir2/dummy3_unittest.cc
tools-webrtc/testdata/subdir/subdir2/dummy4.h
tools-webrtc/testdata/subdir/subdir2/dummy4.cc
tools-webrtc/testdata/subdir/subdir2/dummy_main.cc
View unified diff
|
Download patch
« tools-webrtc/check_package_boundaries_test.py
('K') |
« tools-webrtc/check_package_boundaries_test.py
('k') |
tools-webrtc/testdata/dummy.cc »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
# Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
2
#
3
# Use of this source code is governed by a BSD-style license
4
# that can be found in the LICENSE file in the root of the source
5
# tree. An additional intellectual property rights grant can be found
6
# in the file PATENTS. All contributing project authors may
7
# be found in the AUTHORS file in the root of the source tree.
8
9
group("testdata") {
10
deps = [
11
":one",
12
]
13
}
14
15
static_library("dummy_target") {
16
sources = [
17
"dummy.cc",
18
]
19
deps = [
20
"subdir",
21
]
22
}
OLD
NEW
« tools-webrtc/check_package_boundaries_test.py
('K') |
« tools-webrtc/check_package_boundaries_test.py
('k') |
tools-webrtc/testdata/dummy.cc »
('j') |
no next file with comments »
Issue 2629723004: Add presubmit check to prevent package boundary violations. (Closed)
Created 3 years, 11 months ago by ehmaldonado_webrtc
Modified 3 years, 10 months ago
Reviewers: kjellander_webrtc
Base URL:
Comments: 37
This is Rietveld
408576698
Chromium Code Reviews
Issue 2629723004:
Add presubmit check to prevent package boundary violations. (Closed)
