Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: webrtc/modules/pacing/paced_sender.cc

Issue 2628563003: Propagate packet pacing information to SenTimeHistory (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/pacing/paced_sender.cc
diff --git a/webrtc/modules/pacing/paced_sender.cc b/webrtc/modules/pacing/paced_sender.cc
index a0d7eda73f26f901afbf29de7abc051034b68ae9..c2d734505a21db7f51d581ec7e22ba4a30c21893 100644
--- a/webrtc/modules/pacing/paced_sender.cc
+++ b/webrtc/modules/pacing/paced_sender.cc
@@ -247,6 +247,11 @@ const int64_t PacedSender::kMaxQueueLengthMs = 2000;
const float PacedSender::kDefaultPaceMultiplier = 2.5f;
PacedSender::PacedSender(Clock* clock, PacketSender* packet_sender)
+ : PacedSender(clock, packet_sender, nullptr) {}
+
+PacedSender::PacedSender(Clock* clock,
+ PacketSender* packet_sender,
+ ProbeClusterCreatedObserver* cluster_created_observer)
: clock_(clock),
packet_sender_(packet_sender),
alr_detector_(new AlrDetector()),
@@ -254,7 +259,7 @@ PacedSender::PacedSender(Clock* clock, PacketSender* packet_sender)
paused_(false),
media_budget_(new paced_sender::IntervalBudget(0)),
padding_budget_(new paced_sender::IntervalBudget(0)),
- prober_(new BitrateProber()),
+ prober_(new BitrateProber(cluster_created_observer)),
nisse-webrtc 2017/01/10 16:04:41 If this thing is owned by the PacedSender, which i
philipel 2017/01/11 09:03:33 I can't see how we could avoid using a callback in
estimated_bitrate_bps_(0),
min_send_bitrate_kbps_(0u),
max_padding_bitrate_kbps_(0u),
« webrtc/modules/pacing/bitrate_prober.h ('K') | « webrtc/modules/pacing/paced_sender.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698