Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: webrtc/api/peerconnectionfactoryproxy.h

Issue 2628343003: Adding some features to proxy.h, and restructuring the macros. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/peerconnectionfactoryproxy.h
diff --git a/webrtc/api/peerconnectionfactoryproxy.h b/webrtc/api/peerconnectionfactoryproxy.h
index 227a685b7e23b258f8bb33fc3104e21412cb9c98..032b3685d7b2ebe20c79a1494f93465164896078 100644
--- a/webrtc/api/peerconnectionfactoryproxy.h
+++ b/webrtc/api/peerconnectionfactoryproxy.h
@@ -22,6 +22,7 @@
namespace webrtc {
BEGIN_SIGNALING_PROXY_MAP(PeerConnectionFactory)
+ PROXY_SIGNALING_THREAD_DESTRUCTOR()
PROXY_METHOD1(void, SetOptions, const Options&)
// Can't use PROXY_METHOD5 because unique_ptr must be moved.
// TODO(tommi,hbos): Use of templates to support unique_ptr?
@@ -99,7 +100,7 @@ BEGIN_SIGNALING_PROXY_MAP(PeerConnectionFactory)
return c_->CreatePeerConnection(a1, std::move(ptr_a3), std::move(ptr_a4),
a5);
}
- END_SIGNALING_PROXY()
+ END_PROXY_MAP()
pthatcher1 2017/01/17 19:44:00 It seems like the end should match the begin. So
Taylor Brandstetter 2017/01/18 01:17:14 I don't see much benefit to that. Plus, code would
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698