Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: webrtc/video/receive_statistics_proxy_unittest.cc

Issue 2627463004: Make the new jitter buffer the default jitter buffer. (Closed)
Patch Set: Offline feedback. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/receive_statistics_proxy_unittest.cc
diff --git a/webrtc/video/receive_statistics_proxy_unittest.cc b/webrtc/video/receive_statistics_proxy_unittest.cc
index dc944d59e3b70eca876d195e5c1447421b95c56e..b377bfe4689f14939ca7de8b7660155a168201d1 100644
--- a/webrtc/video/receive_statistics_proxy_unittest.cc
+++ b/webrtc/video/receive_statistics_proxy_unittest.cc
@@ -74,14 +74,6 @@ TEST_F(ReceiveStatisticsProxyTest, GetStatsReportsDecoderImplementationName) {
kName, statistics_proxy_->GetStats().decoder_implementation_name.c_str());
}
-TEST_F(ReceiveStatisticsProxyTest, GetStatsReportsIncomingRate) {
terelius 2017/01/12 13:08:34 Is this no longer relevant, or is there some other
philipel 2017/01/12 16:41:35 Since the old jitter buffer wont be used anymore n
- const int kFramerate = 28;
- const int kBitrateBps = 311000;
- statistics_proxy_->OnIncomingRate(kFramerate, kBitrateBps);
stefan-webrtc 2017/01/12 14:16:15 Perhaps replace this with calls to OnCompleteFrame
philipel 2017/01/12 16:41:35 Done.
- EXPECT_EQ(kFramerate, statistics_proxy_->GetStats().network_frame_rate);
- EXPECT_EQ(kBitrateBps, statistics_proxy_->GetStats().total_bitrate_bps);
-}
-
TEST_F(ReceiveStatisticsProxyTest, GetStatsReportsDecodeTimingStats) {
const int kDecodeMs = 1;
const int kMaxDecodeMs = 2;
@@ -91,9 +83,10 @@ TEST_F(ReceiveStatisticsProxyTest, GetStatsReportsDecodeTimingStats) {
const int kMinPlayoutDelayMs = 6;
const int kRenderDelayMs = 7;
const int64_t kRttMs = 8;
- statistics_proxy_->OnDecoderTiming(
- kDecodeMs, kMaxDecodeMs, kCurrentDelayMs, kTargetDelayMs, kJitterBufferMs,
- kMinPlayoutDelayMs, kRenderDelayMs, kRttMs);
+ statistics_proxy_->OnRttUpdate(kRttMs, 0);
+ statistics_proxy_->OnDecoderTiming(kDecodeMs, kMaxDecodeMs, kCurrentDelayMs,
+ kTargetDelayMs, kJitterBufferMs,
+ kMinPlayoutDelayMs, kRenderDelayMs);
VideoReceiveStream::Stats stats = statistics_proxy_->GetStats();
EXPECT_EQ(kDecodeMs, stats.decode_ms);
EXPECT_EQ(kMaxDecodeMs, stats.max_decode_ms);

Powered by Google App Engine
This is Rietveld 408576698