Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: webrtc/video/end_to_end_tests.cc

Issue 2627463004: Make the new jitter buffer the default jitter buffer. (Closed)
Patch Set: Offline feedback. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/end_to_end_tests.cc
diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc
index 61b75af315405e4f8ad74dcfd1f720a9242f6b1d..b795b895a85b800c6363f893b10ab086989fd3cd 100644
--- a/webrtc/video/end_to_end_tests.cc
+++ b/webrtc/video/end_to_end_tests.cc
@@ -1184,13 +1184,6 @@ TEST_P(EndToEndTest, ReceivesPliAndRecoversWithNack) {
ReceivesPliAndRecovers(1000);
}
-TEST_P(EndToEndTest, ReceivesPliAndRecoversWithoutNack) {
- // This test makes no sense for the new video jitter buffer.
- if (GetParam() == new_jb_enabled)
- return;
- ReceivesPliAndRecovers(0);
-}
-
stefan-webrtc 2017/01/12 14:16:15 As mentioned offline, I'm not sure we want to dele
philipel 2017/01/12 16:41:35 Fixed the NackModule to not send NACKs when histor
TEST_P(EndToEndTest, UnknownRtpPacketGivesUnknownSsrcReturnCode) {
class PacketInputObserver : public PacketReceiver {
public:
@@ -2987,10 +2980,6 @@ TEST_P(EndToEndTest, GetStats) {
ReceiveStreamRenderer receive_stream_renderer_;
} test;
- // TODO(philipel): Implement statistics for the new video jitter buffer.
- if (GetParam() == new_jb_enabled)
- return;
-
RunBaseTest(&test);
}

Powered by Google App Engine
This is Rietveld 408576698