Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1364)

Unified Diff: webrtc/sdk/android/instrumentationtests/src/org/webrtc/PeerConnectionTest.java

Issue 2627043002: Update Android instrumentation tests to use JUnit4. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/android/instrumentationtests/src/org/webrtc/PeerConnectionTest.java
diff --git a/webrtc/sdk/android/instrumentationtests/src/org/webrtc/PeerConnectionTest.java b/webrtc/sdk/android/instrumentationtests/src/org/webrtc/PeerConnectionTest.java
index 845f54580b3f84e264bacdc7382e64dd7f20b386..418b9337f1e11b5de81dcec25144b59577927d8c 100644
--- a/webrtc/sdk/android/instrumentationtests/src/org/webrtc/PeerConnectionTest.java
+++ b/webrtc/sdk/android/instrumentationtests/src/org/webrtc/PeerConnectionTest.java
@@ -10,14 +10,14 @@
package org.webrtc;
-import org.webrtc.Metrics.HistogramInfo;
-import org.webrtc.PeerConnection.IceConnectionState;
-import org.webrtc.PeerConnection.IceGatheringState;
-import org.webrtc.PeerConnection.SignalingState;
-
-import android.test.ActivityTestCase;
-import android.test.suitebuilder.annotation.MediumTest;
-
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertTrue;
+
+import android.support.test.InstrumentationRegistry;
+import android.support.test.filters.MediumTest;
import java.io.File;
import java.lang.ref.WeakReference;
import java.nio.ByteBuffer;
@@ -31,16 +31,25 @@ import java.util.Map;
import java.util.TreeSet;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;
+import org.chromium.base.test.BaseJUnit4ClassRunner;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.webrtc.Metrics.HistogramInfo;
+import org.webrtc.PeerConnection.IceConnectionState;
+import org.webrtc.PeerConnection.IceGatheringState;
+import org.webrtc.PeerConnection.SignalingState;
/** End-to-end tests for PeerConnection.java. */
-public class PeerConnectionTest extends ActivityTestCase {
+@RunWith(BaseJUnit4ClassRunner.class)
+public class PeerConnectionTest {
private static final int TIMEOUT_SECONDS = 20;
private TreeSet<String> threadsBeforeTest = null;
- @Override
- protected void setUp() {
+ @Before
+ public void setUp() {
assertTrue(PeerConnectionFactory.initializeAndroidGlobals(
- getInstrumentation().getContext(), true, true, true));
+ InstrumentationRegistry.getContext(), true, true, true));
}
private static class ObserverExpectations
@@ -539,6 +548,7 @@ public class PeerConnectionTest extends ActivityTestCase {
// in JNI-style programming; make sure no typos!
// - Test that shutdown mid-interaction is crash-free.
+ @Test
@MediumTest
public void testCompleteSession() throws Exception {
Metrics.enable();
@@ -766,6 +776,7 @@ public class PeerConnectionTest extends ActivityTestCase {
System.gc();
}
+ @Test
@MediumTest
public void testTrackRemovalAndAddition() throws Exception {
// Allow loopback interfaces too since our Android devices often don't

Powered by Google App Engine
This is Rietveld 408576698