Replace ASSERT(false) by RTC_NOTREACHED().

webrtc/p2p/client/basicportallocator.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 437 matching lines @@
     break;
   case MSG_SEQUENCEOBJECTS_CREATED:
     ASSERT(rtc::Thread::Current() == network_thread_);
     OnAllocationSequenceObjectsCreated();
     break;
   case MSG_CONFIG_STOP:
     ASSERT(rtc::Thread::Current() == network_thread_);
     OnConfigStop();
     break;
   default:
-    ASSERT(false);
+    RTC_NOTREACHED();
   }
 }
 
 void BasicPortAllocatorSession::UpdateIceParametersInternal() {
   for (PortData& port : ports_) {
     port.port()->set_content_name(content_name());
     port.port()->SetIceParameters(component(), ice_ufrag(), ice_pwd());
   }
 }
 
@@ skipping 499 matching lines @@
   ASSERT(rtc::Thread::Current() == network_thread_);
   for (std::vector<PortData>::iterator iter = ports_.begin();
        iter != ports_.end(); ++iter) {
     if (port == iter->port()) {
       ports_.erase(iter);
       LOG_J(LS_INFO, port) << "Removed port from allocator ("
                            << static_cast<int>(ports_.size()) << " remaining)";
       return;
     }
   }
-  ASSERT(false);
+  RTC_NOTREACHED();
 }
 
 BasicPortAllocatorSession::PortData* BasicPortAllocatorSession::FindPort(
     Port* port) {
   for (std::vector<PortData>::iterator it = ports_.begin();
        it != ports_.end(); ++it) {
     if (it->port() == port) {
       return &*it;
     }
   }
@@ skipping 160 matching lines @@
       CreateTCPPorts();
       EnableProtocol(PROTO_TCP);
       break;
 
     case PHASE_SSLTCP:
       state_ = kCompleted;
       EnableProtocol(PROTO_SSLTCP);
       break;
 
     default:
-      ASSERT(false);
+      RTC_NOTREACHED();
   }
 
   if (state() == kRunning) {
     ++phase_;
     session_->network_thread()->PostDelayed(RTC_FROM_HERE,
                                             session_->allocator()->step_delay(),
                                             this, MSG_ALLOCATION_PHASE);
   } else {
     // If all phases in AllocationSequence are completed, no allocation
     // steps needed further. Canceling  pending signal.
@@ skipping 128 matching lines @@
         << "AllocationSequence: No relay server configured, skipping.";
     return;
   }
 
   for (RelayServerConfig& relay : config_->relays) {
     if (relay.type == RELAY_GTURN) {
       CreateGturnPort(relay);
     } else if (relay.type == RELAY_TURN) {
       CreateTurnPort(relay);
     } else {
-      ASSERT(false);
+      RTC_NOTREACHED();
     }
   }
 }
 
 void AllocationSequence::CreateGturnPort(const RelayServerConfig& config) {
   // TODO(mallinath) - Rename RelayPort to GTurnPort.
   RelayPort* port = RelayPort::Create(session_->network_thread(),
                                       session_->socket_factory(),
                                       network_, ip_,
                                       session_->allocator()->min_port(),
@@ skipping 122 matching lines @@
   if (udp_port_ == port) {
     udp_port_ = NULL;
     return;
   }
 
   auto it = std::find(turn_ports_.begin(), turn_ports_.end(), port);
   if (it != turn_ports_.end()) {
     turn_ports_.erase(it);
   } else {
     LOG(LS_ERROR) << "Unexpected OnPortDestroyed for nonexistent port.";
-    ASSERT(false);
+    RTC_NOTREACHED();
   }
 }
 
 // PortConfiguration
 PortConfiguration::PortConfiguration(
     const rtc::SocketAddress& stun_address,
     const std::string& username,
     const std::string& password)
     : stun_address(stun_address), username(username), password(password) {
   if (!stun_address.IsNil())
@@ skipping 56 matching lines @@
   ServerAddresses servers;
   for (size_t i = 0; i < relays.size(); ++i) {
     if (relays[i].type == turn_type && SupportsProtocol(relays[i], type)) {
       servers.insert(relays[i].ports.front().address);
     }
   }
   return servers;
 }
 
 }  // namespace cricket