Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: webrtc/media/engine/internalencoderfactory.cc

Issue 2623513002: Explicitly only add transport-cc RTCP feedback param to default FlexFEC codec. (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/media/engine/webrtcvideoengine2.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 supported_codecs_.push_back(cricket::VideoCodec(kRedCodecName)); 46 supported_codecs_.push_back(cricket::VideoCodec(kRedCodecName));
47 supported_codecs_.push_back(cricket::VideoCodec(kUlpfecCodecName)); 47 supported_codecs_.push_back(cricket::VideoCodec(kUlpfecCodecName));
48 48
49 if (IsFlexfecFieldTrialEnabled()) { 49 if (IsFlexfecFieldTrialEnabled()) {
50 cricket::VideoCodec flexfec_codec(kFlexfecCodecName); 50 cricket::VideoCodec flexfec_codec(kFlexfecCodecName);
51 // This value is currently arbitrarily set to 10 seconds. (The unit 51 // This value is currently arbitrarily set to 10 seconds. (The unit
52 // is microseconds.) This parameter MUST be present in the SDP, but 52 // is microseconds.) This parameter MUST be present in the SDP, but
53 // we never use the actual value anywhere in our code however. 53 // we never use the actual value anywhere in our code however.
54 // TODO(brandtr): Consider honouring this value in the sender and receiver. 54 // TODO(brandtr): Consider honouring this value in the sender and receiver.
55 flexfec_codec.SetParam(kFlexfecFmtpRepairWindow, "10000000"); 55 flexfec_codec.SetParam(kFlexfecFmtpRepairWindow, "10000000");
56 flexfec_codec.AddFeedbackParam(
57 FeedbackParam(kRtcpFbParamTransportCc, kParamValueEmpty));
58 flexfec_codec.AddFeedbackParam(
59 FeedbackParam(kRtcpFbParamRemb, kParamValueEmpty));
56 supported_codecs_.push_back(flexfec_codec); 60 supported_codecs_.push_back(flexfec_codec);
57 } 61 }
58 } 62 }
59 63
60 InternalEncoderFactory::~InternalEncoderFactory() {} 64 InternalEncoderFactory::~InternalEncoderFactory() {}
61 65
62 // WebRtcVideoEncoderFactory implementation. 66 // WebRtcVideoEncoderFactory implementation.
63 webrtc::VideoEncoder* InternalEncoderFactory::CreateVideoEncoder( 67 webrtc::VideoEncoder* InternalEncoderFactory::CreateVideoEncoder(
64 const cricket::VideoCodec& codec) { 68 const cricket::VideoCodec& codec) {
65 const webrtc::VideoCodecType codec_type = 69 const webrtc::VideoCodecType codec_type =
(...skipping 15 matching lines...) Expand all
81 InternalEncoderFactory::supported_codecs() const { 85 InternalEncoderFactory::supported_codecs() const {
82 return supported_codecs_; 86 return supported_codecs_;
83 } 87 }
84 88
85 void InternalEncoderFactory::DestroyVideoEncoder( 89 void InternalEncoderFactory::DestroyVideoEncoder(
86 webrtc::VideoEncoder* encoder) { 90 webrtc::VideoEncoder* encoder) {
87 delete encoder; 91 delete encoder;
88 } 92 }
89 93
90 } // namespace cricket 94 } // namespace cricket
OLDNEW
« no previous file with comments | « no previous file | webrtc/media/engine/webrtcvideoengine2.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698