Replace all use of the VERIFY macro.

webrtc/p2p/base/turnport.cc

 /*
  *  Copyright 2012 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 909 matching lines @@
   LOG_J(LS_INFO, this) << "Scheduled refresh in " << delay << "ms.";
   return true;
 }
 
 void TurnPort::SendRequest(StunRequest* req, int delay) {
   request_manager_.SendDelayed(req, delay);
 }
 
 void TurnPort::AddRequestAuthInfo(StunMessage* msg) {
   // If we've gotten the necessary data from the server, add it to our request.
-  VERIFY(!hash_.empty());
+  RTC_DCHECK(!hash_.empty());
   msg->AddAttribute(new StunByteStringAttribute(
       STUN_ATTR_USERNAME, credentials_.username));
   msg->AddAttribute(new StunByteStringAttribute(
       STUN_ATTR_REALM, realm_));
   msg->AddAttribute(new StunByteStringAttribute(
       STUN_ATTR_NONCE, nonce_));
-  VERIFY(msg->AddMessageIntegrity(hash()));
+  bool res = msg->AddMessageIntegrity(hash());
+  RTC_DCHECK(res);
 }
 
 int TurnPort::Send(const void* data, size_t len,
                    const rtc::PacketOptions& options) {
   return socket_->SendTo(data, len, server_address_.address, options);
 }
 
 void TurnPort::UpdateHash() {
-  VERIFY(ComputeStunCredentialHash(credentials_.username, realm_,
-                                   credentials_.password, &hash_));
+  bool res = ComputeStunCredentialHash(credentials_.username, realm_,
+                                       credentials_.password, &hash_);
+  RTC_DCHECK(res);
 }
 
 bool TurnPort::UpdateNonce(StunMessage* response) {
   // When stale nonce error received, we should update
   // hash and store realm and nonce.
   // Check the mandatory attributes.
   const StunByteStringAttribute* realm_attr =
       response->GetByteString(STUN_ATTR_REALM);
   if (!realm_attr) {
     LOG(LS_ERROR) << "Missing STUN_ATTR_REALM attribute in "
@@ skipping 510 matching lines @@
   if (state_ != STATE_BOUND) {
     // If we haven't bound the channel yet, we have to use a Send Indication.
     TurnMessage msg;
     msg.SetType(TURN_SEND_INDICATION);
     msg.SetTransactionID(
         rtc::CreateRandomString(kStunTransactionIdLength));
     msg.AddAttribute(new StunXorAddressAttribute(
         STUN_ATTR_XOR_PEER_ADDRESS, ext_addr_));
     msg.AddAttribute(new StunByteStringAttribute(
         STUN_ATTR_DATA, data, size));
-    VERIFY(msg.Write(&buf));
+    bool res = msg.Write(&buf);
+    RTC_DCHECK (res);

[kwiberg-webrtc, 2017/02/07 09:39:49]

Spurious space again. Doesn't clang-format fix these?

[nisse-webrtc, 2017/02/07 10:48:16]

I'll run git cl format for the next patchset. I often hack on code following the
GNU coding standard, which prefers space before open paren...

 
     // If we're sending real data, request a channel bind that we can use later.
     if (state_ == STATE_UNBOUND && payload) {
       SendChannelBindRequest(0);
       state_ = STATE_BINDING;
     }
   } else {
     // If the channel is bound, we can send the data as a Channel Message.
     buf.WriteUInt16(channel_id_);
     buf.WriteUInt16(static_cast<uint16_t>(size));
@@ skipping 60 matching lines @@
   } else {
     state_ = STATE_UNBOUND;
     port_->FailAndPruneConnection(ext_addr_);
   }
 }
 void TurnEntry::OnChannelBindTimeout() {
   state_ = STATE_UNBOUND;
   port_->FailAndPruneConnection(ext_addr_);
 }
 }  // namespace cricket