Replace all use of the VERIFY macro.

webrtc/p2p/base/dtlstransportchannel.cc

 /*
  *  Copyright 2011 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 336 matching lines @@
         requested_str.append(" ");
       }
       LOG(LS_WARNING) << "Ignoring new set of SRTP ciphers, as DTLS "
                       << "renegotiation is not supported currently "
                       << "current cipher = " << current_srtp_cipher << " and "
                       << "requested = " << "[" << requested_str << "]";
     }
     return true;
   }
 
-  if (!VERIFY(dtls_state() == DTLS_TRANSPORT_NEW)) {
+  // TODO(nisse): Bad style of error handling. Should it be a DCHECK or not?

[nisse-webrtc, 2017/02/07 10:48:15]

And what to do about this case?

[kwiberg-webrtc, 2017/02/07 11:45:08]

Dunno. The code should either handle the error, or it should never occur. Just
about the only thing we can be sure of is that our unit tests don't exercise the
error path, since that would have triggered the DCHECK...

Hmm. I just realized that that's a succinct way of explaining why you should
never handle DCHECK failures: the DCHECK works as a guard ensuring that the
error path is never tested...

But back to the immediate problem. I guess one sane way to treat this is to use
CHECK instead of DCHECK, and delete the error handling code, plus leaving a TODO
for yourself to replace the CHECK with a DCHECK in 3-6 months if it never
triggered.

[nisse-webrtc, 2017/02/07 13:52:40]

After looking at the other code in this file, it seems other methods return
error when in an unexpected state, so I'm doing the same here and just delete
the DCHECK.

+  RTC_DCHECK(dtls_state() == DTLS_TRANSPORT_NEW);
+  if (dtls_state() != DTLS_TRANSPORT_NEW) {
     return false;
   }
 
   srtp_ciphers_ = ciphers;
   return true;
 }
 
 bool DtlsTransport::GetSrtpCryptoSuite(int* cipher) {
   if (dtls_state() != DTLS_TRANSPORT_CONNECTED) {
     return false;
@@ skipping 346 matching lines @@
 
     dtls_->SetInitialRetransmissionTimeout(initial_timeout);
   } else {
     LOG_J(LS_INFO, this)
         << "no RTT estimate - using default DTLS handshake timeout";
   }
 }
 
 
 }  // namespace cricket