Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: webrtc/base/stringencode.cc

Issue 2623313004: Replace RTC_DCHECK(false) with RTC_NOTREACHED(). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/network.cc ('k') | webrtc/base/timeutils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/stringencode.cc
diff --git a/webrtc/base/stringencode.cc b/webrtc/base/stringencode.cc
index ab04d0285659a393da654d3015c29acbe0286eef..7c11a05e3e916c5a9c1015a0208448182bb01286 100644
--- a/webrtc/base/stringencode.cc
+++ b/webrtc/base/stringencode.cc
@@ -119,7 +119,7 @@ const char* unsafe_filename_characters() {
return "\\/:*?\"<>|";
#else // !WEBRTC_WIN
// TODO(grunell): Should this never be reached?
- RTC_DCHECK(false);
+ RTC_NOTREACHED();
return "";
#endif // !WEBRTC_WIN
}
@@ -274,7 +274,7 @@ size_t html_encode(char * buffer, size_t buflen,
case '\'': escseq = "&#39;"; esclen = 5; break;
case '\"': escseq = "&quot;"; esclen = 6; break;
case '&': escseq = "&amp;"; esclen = 5; break;
- default: RTC_DCHECK(false);
+ default: RTC_NOTREACHED();
}
if (bufpos + esclen >= buflen) {
break;
@@ -331,7 +331,7 @@ size_t xml_encode(char * buffer, size_t buflen,
case '\'': escseq = "&apos;"; esclen = 6; break;
case '\"': escseq = "&quot;"; esclen = 6; break;
case '&': escseq = "&amp;"; esclen = 5; break;
- default: RTC_DCHECK(false);
+ default: RTC_NOTREACHED();
}
if (bufpos + esclen >= buflen) {
break;
« no previous file with comments | « webrtc/base/network.cc ('k') | webrtc/base/timeutils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698