Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: webrtc/p2p/base/transportcontroller.cc

Issue 2623313004: Replace RTC_DCHECK(false) with RTC_NOTREACHED(). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/p2p/base/p2ptransportchannel.cc ('k') | webrtc/p2p/client/basicportallocator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2015 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 741 matching lines...) Expand 10 before | Expand all | Expand 10 after
752 UpdateAggregateStates_n(); 752 UpdateAggregateStates_n();
753 } 753 }
754 754
755 void TransportController::OnChannelCandidateGathered_n( 755 void TransportController::OnChannelCandidateGathered_n(
756 TransportChannelImpl* channel, 756 TransportChannelImpl* channel,
757 const Candidate& candidate) { 757 const Candidate& candidate) {
758 RTC_DCHECK(network_thread_->IsCurrent()); 758 RTC_DCHECK(network_thread_->IsCurrent());
759 759
760 // We should never signal peer-reflexive candidates. 760 // We should never signal peer-reflexive candidates.
761 if (candidate.type() == PRFLX_PORT_TYPE) { 761 if (candidate.type() == PRFLX_PORT_TYPE) {
762 RTC_DCHECK(false); 762 RTC_NOTREACHED();
763 return; 763 return;
764 } 764 }
765 std::vector<Candidate> candidates; 765 std::vector<Candidate> candidates;
766 candidates.push_back(candidate); 766 candidates.push_back(candidate);
767 CandidatesData* data = 767 CandidatesData* data =
768 new CandidatesData(channel->transport_name(), candidates); 768 new CandidatesData(channel->transport_name(), candidates);
769 signaling_thread_->Post(RTC_FROM_HERE, this, MSG_CANDIDATESGATHERED, data); 769 signaling_thread_->Post(RTC_FROM_HERE, this, MSG_CANDIDATESGATHERED, data);
770 } 770 }
771 771
772 void TransportController::OnChannelCandidatesRemoved_n( 772 void TransportController::OnChannelCandidatesRemoved_n(
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
869 RTC_FROM_HERE, this, MSG_ICEGATHERINGSTATE, 869 RTC_FROM_HERE, this, MSG_ICEGATHERINGSTATE,
870 new rtc::TypedMessageData<IceGatheringState>(new_gathering_state)); 870 new rtc::TypedMessageData<IceGatheringState>(new_gathering_state));
871 } 871 }
872 } 872 }
873 873
874 void TransportController::OnDtlsHandshakeError(rtc::SSLHandshakeError error) { 874 void TransportController::OnDtlsHandshakeError(rtc::SSLHandshakeError error) {
875 SignalDtlsHandshakeError(error); 875 SignalDtlsHandshakeError(error);
876 } 876 }
877 877
878 } // namespace cricket 878 } // namespace cricket
OLDNEW
« no previous file with comments | « webrtc/p2p/base/p2ptransportchannel.cc ('k') | webrtc/p2p/client/basicportallocator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698