Replace RTC_DCHECK(false) with RTC_NOTREACHED().

webrtc/p2p/base/p2ptransportchannel.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 1402 matching lines @@
         // we shouldn't go from COMPLETED to CONNECTING.
         // Though we *can* go from COMPlETED to FAILED, if consent expires.
         RTC_DCHECK(state == STATE_CONNECTING || state == STATE_FAILED);
         break;
       case STATE_FAILED:
         // TODO(deadbeef): Once we implement end-of-candidates signaling,
         // we shouldn't go from FAILED to CONNECTING or COMPLETED.
         RTC_DCHECK(state == STATE_CONNECTING || state == STATE_COMPLETED);
         break;
       default:
-        RTC_DCHECK(false);
+        RTC_NOTREACHED();
         break;
     }
     state_ = state;
     SignalStateChanged(this);
   }
 
   // If our selected connection is "presumed writable" (TURN-TURN with no
   // CreatePermission required), act like we're already writable to the upper
   // layers, so they can start media quicker.
   bool writable =
@@ skipping 318 matching lines @@
       bool selected = conn == selected_connection_;
       if (remote_ice_mode_ == ICEMODE_LITE) {
         return selected && conn->writable();
       }
       bool better_than_selected =
           !selected_connection_ || !selected_connection_->writable() ||
           CompareConnectionCandidates(selected_connection_, conn) < 0;
       return selected || better_than_selected;
     }
     default:
-      RTC_DCHECK(false);
+      RTC_NOTREACHED();
       return false;
   }
 }
 
 // When a connection's state changes, we need to figure out who to use as
 // the selected connection again.  It could have become usable, or become
 // unusable.
 void P2PTransportChannel::OnConnectionStateChange(Connection* connection) {
   ASSERT(network_thread_ == rtc::Thread::Current());
 
@@ skipping 235 matching lines @@
 
   // During the initial state when nothing has been pinged yet, return the first
   // one in the ordered |connections_|.
   return *(std::find_if(connections_.begin(), connections_.end(),
                         [conn1, conn2](Connection* conn) {
                           return conn == conn1 || conn == conn2;
                         }));
 }
 
 }  // namespace cricket