Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: webrtc/media/engine/webrtcvideoengine2.cc

Issue 2623313004: Replace RTC_DCHECK(false) with RTC_NOTREACHED(). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 1725 matching lines...) Expand 10 before | Expand all | Expand 10 after
1736 1736
1737 // Try creating internal encoder. 1737 // Try creating internal encoder.
1738 InternalEncoderFactory internal_encoder_factory; 1738 InternalEncoderFactory internal_encoder_factory;
1739 if (FindMatchingCodec(internal_encoder_factory.supported_codecs(), codec)) { 1739 if (FindMatchingCodec(internal_encoder_factory.supported_codecs(), codec)) {
1740 return AllocatedEncoder(internal_encoder_factory.CreateVideoEncoder(codec), 1740 return AllocatedEncoder(internal_encoder_factory.CreateVideoEncoder(codec),
1741 codec, false /* is_external */); 1741 codec, false /* is_external */);
1742 } 1742 }
1743 1743
1744 // This shouldn't happen, we should not be trying to create something we don't 1744 // This shouldn't happen, we should not be trying to create something we don't
1745 // support. 1745 // support.
1746 RTC_DCHECK(false); 1746 RTC_NOTREACHED();
1747 return AllocatedEncoder(NULL, cricket::VideoCodec(), false); 1747 return AllocatedEncoder(NULL, cricket::VideoCodec(), false);
1748 } 1748 }
1749 1749
1750 void WebRtcVideoChannel2::WebRtcVideoSendStream::DestroyVideoEncoder( 1750 void WebRtcVideoChannel2::WebRtcVideoSendStream::DestroyVideoEncoder(
1751 AllocatedEncoder* encoder) { 1751 AllocatedEncoder* encoder) {
1752 RTC_DCHECK_RUN_ON(&thread_checker_); 1752 RTC_DCHECK_RUN_ON(&thread_checker_);
1753 if (encoder->external) { 1753 if (encoder->external) {
1754 external_encoder_factory_->DestroyVideoEncoder(encoder->external_encoder); 1754 external_encoder_factory_->DestroyVideoEncoder(encoder->external_encoder);
1755 } 1755 }
1756 delete encoder->encoder; 1756 delete encoder->encoder;
(...skipping 830 matching lines...) Expand 10 before | Expand all | Expand 10 after
2587 rtx_mapping[video_codecs[i].codec.id] != 2587 rtx_mapping[video_codecs[i].codec.id] !=
2588 ulpfec_config.red_payload_type) { 2588 ulpfec_config.red_payload_type) {
2589 video_codecs[i].rtx_payload_type = rtx_mapping[video_codecs[i].codec.id]; 2589 video_codecs[i].rtx_payload_type = rtx_mapping[video_codecs[i].codec.id];
2590 } 2590 }
2591 } 2591 }
2592 2592
2593 return video_codecs; 2593 return video_codecs;
2594 } 2594 }
2595 2595
2596 } // namespace cricket 2596 } // namespace cricket
OLDNEW
« no previous file with comments | « webrtc/common_audio/vad/vad.cc ('k') | webrtc/modules/audio_processing/echo_control_mobile_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698