Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: webrtc/pc/channelmanager.h

Issue 2622613004: Refactoring of RTCP options in BaseChannel. (Closed)
Patch Set: Minor renaming/adding a comment, which makes sense to do after this refactoring. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/pc/channel_unittest.cc ('k') | webrtc/pc/channelmanager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 88
89 // The operations below all occur on the worker thread. 89 // The operations below all occur on the worker thread.
90 // Creates a voice channel, to be associated with the specified session. 90 // Creates a voice channel, to be associated with the specified session.
91 VoiceChannel* CreateVoiceChannel( 91 VoiceChannel* CreateVoiceChannel(
92 webrtc::MediaControllerInterface* media_controller, 92 webrtc::MediaControllerInterface* media_controller,
93 TransportChannel* rtp_transport, 93 TransportChannel* rtp_transport,
94 TransportChannel* rtcp_transport, 94 TransportChannel* rtcp_transport,
95 rtc::Thread* signaling_thread, 95 rtc::Thread* signaling_thread,
96 const std::string& content_name, 96 const std::string& content_name,
97 const std::string* bundle_transport_name, 97 const std::string* bundle_transport_name,
98 bool rtcp, 98 bool rtcp_mux_required,
99 bool srtp_required, 99 bool srtp_required,
100 const AudioOptions& options); 100 const AudioOptions& options);
101 // Destroys a voice channel created with the Create API. 101 // Destroys a voice channel created with the Create API.
102 void DestroyVoiceChannel(VoiceChannel* voice_channel); 102 void DestroyVoiceChannel(VoiceChannel* voice_channel);
103 // Creates a video channel, synced with the specified voice channel, and 103 // Creates a video channel, synced with the specified voice channel, and
104 // associated with the specified session. 104 // associated with the specified session.
105 VideoChannel* CreateVideoChannel( 105 VideoChannel* CreateVideoChannel(
106 webrtc::MediaControllerInterface* media_controller, 106 webrtc::MediaControllerInterface* media_controller,
107 TransportChannel* rtp_transport, 107 TransportChannel* rtp_transport,
108 TransportChannel* rtcp_transport, 108 TransportChannel* rtcp_transport,
109 rtc::Thread* signaling_thread, 109 rtc::Thread* signaling_thread,
110 const std::string& content_name, 110 const std::string& content_name,
111 const std::string* bundle_transport_name, 111 const std::string* bundle_transport_name,
112 bool rtcp, 112 bool rtcp_mux_required,
113 bool srtp_required, 113 bool srtp_required,
114 const VideoOptions& options); 114 const VideoOptions& options);
115 // Destroys a video channel created with the Create API. 115 // Destroys a video channel created with the Create API.
116 void DestroyVideoChannel(VideoChannel* video_channel); 116 void DestroyVideoChannel(VideoChannel* video_channel);
117 RtpDataChannel* CreateRtpDataChannel( 117 RtpDataChannel* CreateRtpDataChannel(
118 webrtc::MediaControllerInterface* media_controller, 118 webrtc::MediaControllerInterface* media_controller,
119 TransportChannel* rtp_transport, 119 TransportChannel* rtp_transport,
120 TransportChannel* rtcp_transport, 120 TransportChannel* rtcp_transport,
121 rtc::Thread* signaling_thread, 121 rtc::Thread* signaling_thread,
122 const std::string& content_name, 122 const std::string& content_name,
123 const std::string* bundle_transport_name, 123 const std::string* bundle_transport_name,
124 bool rtcp, 124 bool rtcp_mux_required,
125 bool srtp_required); 125 bool srtp_required);
126 // Destroys a data channel created with the Create API. 126 // Destroys a data channel created with the Create API.
127 void DestroyRtpDataChannel(RtpDataChannel* data_channel); 127 void DestroyRtpDataChannel(RtpDataChannel* data_channel);
128 128
129 // Indicates whether any channels exist. 129 // Indicates whether any channels exist.
130 bool has_channels() const { 130 bool has_channels() const {
131 return (!voice_channels_.empty() || !video_channels_.empty()); 131 return (!voice_channels_.empty() || !video_channels_.empty());
132 } 132 }
133 133
134 // RTX will be enabled/disabled in engines that support it. The supporting 134 // RTX will be enabled/disabled in engines that support it. The supporting
(...skipping 30 matching lines...) Expand all
165 void DestructorDeletes_w(); 165 void DestructorDeletes_w();
166 void Terminate_w(); 166 void Terminate_w();
167 bool SetCryptoOptions_w(const rtc::CryptoOptions& crypto_options); 167 bool SetCryptoOptions_w(const rtc::CryptoOptions& crypto_options);
168 VoiceChannel* CreateVoiceChannel_w( 168 VoiceChannel* CreateVoiceChannel_w(
169 webrtc::MediaControllerInterface* media_controller, 169 webrtc::MediaControllerInterface* media_controller,
170 TransportChannel* rtp_transport, 170 TransportChannel* rtp_transport,
171 TransportChannel* rtcp_transport, 171 TransportChannel* rtcp_transport,
172 rtc::Thread* signaling_thread, 172 rtc::Thread* signaling_thread,
173 const std::string& content_name, 173 const std::string& content_name,
174 const std::string* bundle_transport_name, 174 const std::string* bundle_transport_name,
175 bool rtcp, 175 bool rtcp_mux_required,
176 bool srtp_required, 176 bool srtp_required,
177 const AudioOptions& options); 177 const AudioOptions& options);
178 void DestroyVoiceChannel_w(VoiceChannel* voice_channel); 178 void DestroyVoiceChannel_w(VoiceChannel* voice_channel);
179 VideoChannel* CreateVideoChannel_w( 179 VideoChannel* CreateVideoChannel_w(
180 webrtc::MediaControllerInterface* media_controller, 180 webrtc::MediaControllerInterface* media_controller,
181 TransportChannel* rtp_transport, 181 TransportChannel* rtp_transport,
182 TransportChannel* rtcp_transport, 182 TransportChannel* rtcp_transport,
183 rtc::Thread* signaling_thread, 183 rtc::Thread* signaling_thread,
184 const std::string& content_name, 184 const std::string& content_name,
185 const std::string* bundle_transport_name, 185 const std::string* bundle_transport_name,
186 bool rtcp, 186 bool rtcp_mux_required,
187 bool srtp_required, 187 bool srtp_required,
188 const VideoOptions& options); 188 const VideoOptions& options);
189 void DestroyVideoChannel_w(VideoChannel* video_channel); 189 void DestroyVideoChannel_w(VideoChannel* video_channel);
190 RtpDataChannel* CreateRtpDataChannel_w( 190 RtpDataChannel* CreateRtpDataChannel_w(
191 webrtc::MediaControllerInterface* media_controller, 191 webrtc::MediaControllerInterface* media_controller,
192 TransportChannel* rtp_transport, 192 TransportChannel* rtp_transport,
193 TransportChannel* rtcp_transport, 193 TransportChannel* rtcp_transport,
194 rtc::Thread* signaling_thread, 194 rtc::Thread* signaling_thread,
195 const std::string& content_name, 195 const std::string& content_name,
196 const std::string* bundle_transport_name, 196 const std::string* bundle_transport_name,
197 bool rtcp, 197 bool rtcp_mux_required,
198 bool srtp_required); 198 bool srtp_required);
199 void DestroyRtpDataChannel_w(RtpDataChannel* data_channel); 199 void DestroyRtpDataChannel_w(RtpDataChannel* data_channel);
200 200
201 std::unique_ptr<MediaEngineInterface> media_engine_; 201 std::unique_ptr<MediaEngineInterface> media_engine_;
202 std::unique_ptr<DataEngineInterface> data_media_engine_; 202 std::unique_ptr<DataEngineInterface> data_media_engine_;
203 bool initialized_; 203 bool initialized_;
204 rtc::Thread* main_thread_; 204 rtc::Thread* main_thread_;
205 rtc::Thread* worker_thread_; 205 rtc::Thread* worker_thread_;
206 rtc::Thread* network_thread_; 206 rtc::Thread* network_thread_;
207 207
208 VoiceChannels voice_channels_; 208 VoiceChannels voice_channels_;
209 VideoChannels video_channels_; 209 VideoChannels video_channels_;
210 RtpDataChannels data_channels_; 210 RtpDataChannels data_channels_;
211 211
212 bool enable_rtx_; 212 bool enable_rtx_;
213 rtc::CryptoOptions crypto_options_; 213 rtc::CryptoOptions crypto_options_;
214 214
215 bool capturing_; 215 bool capturing_;
216 }; 216 };
217 217
218 } // namespace cricket 218 } // namespace cricket
219 219
220 #endif // WEBRTC_PC_CHANNELMANAGER_H_ 220 #endif // WEBRTC_PC_CHANNELMANAGER_H_
OLDNEW
« no previous file with comments | « webrtc/pc/channel_unittest.cc ('k') | webrtc/pc/channelmanager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698