Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: webrtc/base/sharedexclusivelock_unittest.cc

Issue 2622413005: Replace use of ASSERT in test code. (Closed)
Patch Set: Fixed another signed/unsigned comparison. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/optionsfile_unittest.cc ('k') | webrtc/base/sslstreamadapter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/sharedexclusivelock_unittest.cc
diff --git a/webrtc/base/sharedexclusivelock_unittest.cc b/webrtc/base/sharedexclusivelock_unittest.cc
index 3886fb27ab1a0771f7f091cc6777ae407b7fb36d..701405ab6fd0da35623cec3b8e620511ba05a2c9 100644
--- a/webrtc/base/sharedexclusivelock_unittest.cc
+++ b/webrtc/base/sharedexclusivelock_unittest.cc
@@ -10,6 +10,7 @@
#include <memory>
+#include "webrtc/base/checks.h"
#include "webrtc/base/common.h"
#include "webrtc/base/gunit.h"
#include "webrtc/base/event.h"
@@ -60,9 +61,9 @@ class ReadTask : public SharedExclusiveTask {
private:
virtual void OnMessage(Message* message) {
- ASSERT(rtc::Thread::Current() == worker_thread_.get());
- ASSERT(message != NULL);
- ASSERT(message->message_id == kMsgRead);
+ RTC_CHECK(rtc::Thread::Current() == worker_thread_.get());
+ RTC_CHECK(message != NULL);
+ RTC_CHECK(message->message_id == kMsgRead);
TypedMessageData<int*>* message_data =
static_cast<TypedMessageData<int*>*>(message->pdata);
@@ -90,9 +91,9 @@ class WriteTask : public SharedExclusiveTask {
private:
virtual void OnMessage(Message* message) {
- ASSERT(rtc::Thread::Current() == worker_thread_.get());
- ASSERT(message != NULL);
- ASSERT(message->message_id == kMsgWrite);
+ RTC_CHECK(rtc::Thread::Current() == worker_thread_.get());
+ RTC_CHECK(message != NULL);
+ RTC_CHECK(message->message_id == kMsgWrite);
TypedMessageData<int>* message_data =
static_cast<TypedMessageData<int>*>(message->pdata);
« no previous file with comments | « webrtc/base/optionsfile_unittest.cc ('k') | webrtc/base/sslstreamadapter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698