Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1473)

Unified Diff: webrtc/api/webrtcsession_unittest.cc

Issue 2622413005: Replace use of ASSERT in test code. (Closed)
Patch Set: Fixed another signed/unsigned comparison. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/test/mockpeerconnectionobservers.h ('k') | webrtc/base/network_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/webrtcsession_unittest.cc
diff --git a/webrtc/api/webrtcsession_unittest.cc b/webrtc/api/webrtcsession_unittest.cc
index 3e1a5833e5e3020c9e1302c2b3fc974c41edc005..ca093155c81bc805215cdbbcd39238f6e6c6e660 100644
--- a/webrtc/api/webrtcsession_unittest.cc
+++ b/webrtc/api/webrtcsession_unittest.cc
@@ -1450,10 +1450,10 @@ class WebRtcSessionTest
bool VerifyNoCNCodecs(const cricket::ContentInfo* content) {
const cricket::ContentDescription* description = content->description;
- ASSERT(description != NULL);
+ RTC_CHECK(description != NULL);
const cricket::AudioContentDescription* audio_content_desc =
static_cast<const cricket::AudioContentDescription*>(description);
- ASSERT(audio_content_desc != NULL);
+ RTC_CHECK(audio_content_desc != NULL);
for (size_t i = 0; i < audio_content_desc->codecs().size(); ++i) {
if (audio_content_desc->codecs()[i].name == "CN")
return false;
@@ -1463,7 +1463,7 @@ class WebRtcSessionTest
void CreateDataChannel() {
webrtc::InternalDataChannelInit dci;
- ASSERT(session_.get());
+ RTC_CHECK(session_.get());
dci.reliable = session_->data_channel_type() == cricket::DCT_SCTP;
data_channel_ = DataChannel::Create(
session_.get(), session_->data_channel_type(), "datachannel", dci);
@@ -3082,7 +3082,7 @@ TEST_F(WebRtcSessionTest, TestIgnoreCandidatesForUnusedTransportWhenBundling) {
session_->video_rtp_transport_channel());
cricket::BaseChannel* voice_channel = session_->voice_channel();
- ASSERT(voice_channel != NULL);
+ ASSERT_TRUE(voice_channel != NULL);
// Checks if one of the transport channels contains a connection using a given
// port.
« no previous file with comments | « webrtc/api/test/mockpeerconnectionobservers.h ('k') | webrtc/base/network_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698