Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Unified Diff: webrtc/api/statscollector_unittest.cc

Issue 2622413005: Replace use of ASSERT in test code. (Closed)
Patch Set: Fixed another signed/unsigned comparison. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/rtcstatscollector_unittest.cc ('k') | webrtc/api/test/fakeaudiocapturemodule.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/statscollector_unittest.cc
diff --git a/webrtc/api/statscollector_unittest.cc b/webrtc/api/statscollector_unittest.cc
index 30bb2b80913b3acb824c3c657f68ded3cb438922..f72e355ac736e9f99e011cc5728fd510af26a5dd 100644
--- a/webrtc/api/statscollector_unittest.cc
+++ b/webrtc/api/statscollector_unittest.cc
@@ -618,7 +618,7 @@ class StatsCollectorTest : public testing::Test {
StatsReports* reports) {
// A track can't have both sender report and recv report at the same time
// for now, this might change in the future though.
- ASSERT((voice_sender_info == NULL) ^ (voice_receiver_info == NULL));
+ EXPECT_TRUE((voice_sender_info == NULL) ^ (voice_receiver_info == NULL));
// Instruct the session to return stats containing the transport channel.
InitSessionStats(vc_name);
@@ -1315,7 +1315,7 @@ TEST_F(StatsCollectorTest, IceCandidateReport) {
uint32_t priority = 1000;
cricket::Candidate c;
- ASSERT(c.id().length() > 0);
+ EXPECT_GT(c.id().length(), 0u);
c.set_type(cricket::LOCAL_PORT_TYPE);
c.set_protocol(cricket::UDP_PROTOCOL_NAME);
c.set_address(local_address);
@@ -1325,7 +1325,7 @@ TEST_F(StatsCollectorTest, IceCandidateReport) {
EXPECT_EQ("Cand-" + c.id(), report_id);
c = cricket::Candidate();
- ASSERT(c.id().length() > 0);
+ EXPECT_GT(c.id().length(), 0u);
c.set_type(cricket::PRFLX_PORT_TYPE);
c.set_protocol(cricket::UDP_PROTOCOL_NAME);
c.set_address(remote_address);
« no previous file with comments | « webrtc/api/rtcstatscollector_unittest.cc ('k') | webrtc/api/test/fakeaudiocapturemodule.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698