Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: webrtc/api/test/mockpeerconnectionobservers.h

Issue 2622413005: Replace use of ASSERT in test code. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/test/mockpeerconnectionobservers.h
diff --git a/webrtc/api/test/mockpeerconnectionobservers.h b/webrtc/api/test/mockpeerconnectionobservers.h
index 2bf0a3a83f7a4ace13c313fac13fa0f59cde5b4f..1339ffdb9d29e67f258376379f228d6fcc0a2452 100644
--- a/webrtc/api/test/mockpeerconnectionobservers.h
+++ b/webrtc/api/test/mockpeerconnectionobservers.h
@@ -17,6 +17,7 @@
#include <string>
#include "webrtc/api/datachannelinterface.h"
+#include "webrtc/base/checks.h"
namespace webrtc {
@@ -109,7 +110,7 @@ class MockStatsObserver : public webrtc::StatsObserver {
virtual ~MockStatsObserver() {}
void OnCompleteReports(std::unique_ptr<StatsReports> reports) override {
- ASSERT(!called_);
+ RTC_CHECK(!called_);
kwiberg-webrtc 2017/01/17 09:39:25 Same situation here as in fakeaudiocapturemodule.c
called_ = true;
stats_.Clear();
stats_.number_of_reports = reports->size();
@@ -143,37 +144,37 @@ class MockStatsObserver : public webrtc::StatsObserver {
double timestamp() const { return stats_.timestamp; }
int AudioOutputLevel() const {
- ASSERT(called_);
+ RTC_CHECK(called_);
return stats_.audio_output_level;
}
int AudioInputLevel() const {
- ASSERT(called_);
+ RTC_CHECK(called_);
return stats_.audio_input_level;
}
int BytesReceived() const {
- ASSERT(called_);
+ RTC_CHECK(called_);
return stats_.bytes_received;
}
int BytesSent() const {
- ASSERT(called_);
+ RTC_CHECK(called_);
return stats_.bytes_sent;
}
int AvailableReceiveBandwidth() const {
- ASSERT(called_);
+ RTC_CHECK(called_);
return stats_.available_receive_bandwidth;
}
std::string DtlsCipher() const {
- ASSERT(called_);
+ RTC_CHECK(called_);
return stats_.dtls_cipher;
}
std::string SrtpCipher() const {
- ASSERT(called_);
+ RTC_CHECK(called_);
return stats_.srtp_cipher;
}

Powered by Google App Engine
This is Rietveld 408576698