Replace use of ASSERT in test code.

webrtc/api/test/fakeaudiocapturemodule.cc

Index: webrtc/api/test/fakeaudiocapturemodule.cc
diff --git a/webrtc/api/test/fakeaudiocapturemodule.cc b/webrtc/api/test/fakeaudiocapturemodule.cc
index f118967cdb0bdeeba5382ea81a59b717313cbbde..c0b761fd3dd64f87d60ec977fbb181379d038abe 100644
--- a/webrtc/api/test/fakeaudiocapturemodule.cc
+++ b/webrtc/api/test/fakeaudiocapturemodule.cc
@@ -639,7 +639,7 @@ void FakeAudioCaptureModule::UpdateProcessing(bool start) {
 }
 
 void FakeAudioCaptureModule::StartProcessP() {
-  ASSERT(process_thread_->IsCurrent());
+  RTC_CHECK(process_thread_->IsCurrent());

[kwiberg-webrtc, 2017/01/17 09:39:25]

CHECK may be the correct choice here, if it is the case that a failing CHECK is
a sign that the test itself is broken rather than that the thing being tested is
broken. Otherwise, I'd think EXPECT_* would be the right choice---unless of
course this code is ever used in a non-test context.

[nisse-webrtc, 2017/01/17 12:19:21]

I don't quite like depending on gtest here. I don't think fake classes should
depend on any particular testing framework, in particular those that live in
api.

Might make sense to switch to RTC_DCHECK in this class, since (i) that's closest
to ASSERT, and (ii) for consistency with typical use of ThreadChecker. 

But on the other hand, I still think RTC_CHECK is, in general, more appropriate
than RTC_DCHECK in test code.

[kwiberg-webrtc, 2017/01/17 13:52:47]

Hmm. OK, CHECK is probably fine. (Since this is test code, there should be no
reason to prefer DCHECK to CHECK, I think.)

   if (started_) {
     // Already started.
     return;
@@ -648,7 +648,7 @@ void FakeAudioCaptureModule::StartProcessP() {
 }
 
 void FakeAudioCaptureModule::ProcessFrameP() {
-  ASSERT(process_thread_->IsCurrent());
+  RTC_CHECK(process_thread_->IsCurrent());
   if (!started_) {
     next_frame_time_ = rtc::TimeMillis();
     started_ = true;
@@ -673,7 +673,7 @@ void FakeAudioCaptureModule::ProcessFrameP() {
 }
 
 void FakeAudioCaptureModule::ReceiveFrameP() {
-  ASSERT(process_thread_->IsCurrent());
+  RTC_CHECK(process_thread_->IsCurrent());
   {
     rtc::CritScope cs(&crit_callback_);
     if (!audio_callback_) {
@@ -689,7 +689,7 @@ void FakeAudioCaptureModule::ReceiveFrameP() {
                                          &elapsed_time_ms, &ntp_time_ms) != 0) {
       RTC_NOTREACHED();
     }
-    ASSERT(nSamplesOut == kNumberSamples);
+    RTC_CHECK(nSamplesOut == kNumberSamples);
   }
   // The SetBuffer() function ensures that after decoding, the audio buffer
   // should contain samples of similar magnitude (there is likely to be some
@@ -704,7 +704,7 @@ void FakeAudioCaptureModule::ReceiveFrameP() {
 }
 
 void FakeAudioCaptureModule::SendFrameP() {
-  ASSERT(process_thread_->IsCurrent());
+  RTC_CHECK(process_thread_->IsCurrent());
   rtc::CritScope cs(&crit_callback_);
   if (!audio_callback_) {
     return;