Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: webrtc/video/video_send_stream.cc

Issue 2621573002: Remove FlexfecConfig and replace with specific struct in VideoSendStream. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/video_quality_test.cc ('k') | webrtc/video_send_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/video_send_stream.cc
diff --git a/webrtc/video/video_send_stream.cc b/webrtc/video/video_send_stream.cc
index 9a3b51e278a0c4f69608e9ea5966f9b82e7f76d2..3757cac9be4688b06ad5a613ede770179b22ab00 100644
--- a/webrtc/video/video_send_stream.cc
+++ b/webrtc/video/video_send_stream.cc
@@ -91,12 +91,12 @@ std::vector<RtpRtcp*> CreateRtpRtcpModules(
// TODO(brandtr): Update this function when we support multistream protection.
std::unique_ptr<FlexfecSender> MaybeCreateFlexfecSender(
const VideoSendStream::Config& config) {
- if (config.rtp.flexfec.flexfec_payload_type < 0) {
+ if (config.rtp.flexfec.payload_type < 0) {
return nullptr;
}
- RTC_DCHECK_GE(config.rtp.flexfec.flexfec_payload_type, 0);
- RTC_DCHECK_LE(config.rtp.flexfec.flexfec_payload_type, 127);
- if (config.rtp.flexfec.flexfec_ssrc == 0) {
+ RTC_DCHECK_GE(config.rtp.flexfec.payload_type, 0);
+ RTC_DCHECK_LE(config.rtp.flexfec.payload_type, 127);
+ if (config.rtp.flexfec.ssrc == 0) {
LOG(LS_WARNING) << "FlexFEC is enabled, but no FlexFEC SSRC given. "
"Therefore disabling FlexFEC.";
return nullptr;
@@ -125,7 +125,7 @@ std::unique_ptr<FlexfecSender> MaybeCreateFlexfecSender(
RTC_DCHECK_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
return std::unique_ptr<FlexfecSender>(new FlexfecSender(
- config.rtp.flexfec.flexfec_payload_type, config.rtp.flexfec.flexfec_ssrc,
+ config.rtp.flexfec.payload_type, config.rtp.flexfec.ssrc,
config.rtp.flexfec.protected_media_ssrcs[0], config.rtp.extensions,
Clock::GetRealTimeClock()));
}
@@ -181,7 +181,17 @@ std::string VideoSendStream::Config::Rtp::ToString() const {
ss << ", nack: {rtp_history_ms: " << nack.rtp_history_ms << '}';
ss << ", ulpfec: " << ulpfec.ToString();
- ss << ", flexfec: " << flexfec.ToString();
+
+ ss << ", flexfec: {payload_type: " << flexfec.payload_type;
+ ss << ", ssrc: " << flexfec.ssrc;
+ ss << ", protected_media_ssrcs: [";
+ size_t i = 0;
+ for (; i + 1 < flexfec.protected_media_ssrcs.size(); ++i)
+ ss << flexfec.protected_media_ssrcs[i] << ", ";
+ if (!flexfec.protected_media_ssrcs.empty())
+ ss << flexfec.protected_media_ssrcs[i];
stefan-webrtc 2017/01/10 11:43:25 Write this code in a similar fashion as line 175-1
brandtr 2017/01/10 12:17:27 Done. Need to land https://codereview.webrtc.org/
+ ss << ']';
+
ss << ", rtx: " << rtx.ToString();
ss << ", c_name: " << c_name;
ss << '}';
« no previous file with comments | « webrtc/video/video_quality_test.cc ('k') | webrtc/video_send_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698