Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Side by Side Diff: webrtc/video/end_to_end_tests.cc

Issue 2621573002: Remove FlexfecConfig and replace with specific struct in VideoSendStream. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include <algorithm> 10 #include <algorithm>
(...skipping 3828 matching lines...) Expand 10 before | Expand all | Expand 10 after
3839 3839
3840 void VerifyEmptyUlpfecConfig(const UlpfecConfig& config) { 3840 void VerifyEmptyUlpfecConfig(const UlpfecConfig& config) {
3841 EXPECT_EQ(-1, config.ulpfec_payload_type) 3841 EXPECT_EQ(-1, config.ulpfec_payload_type)
3842 << "Enabling ULPFEC requires rtpmap: ulpfec negotiation."; 3842 << "Enabling ULPFEC requires rtpmap: ulpfec negotiation.";
3843 EXPECT_EQ(-1, config.red_payload_type) 3843 EXPECT_EQ(-1, config.red_payload_type)
3844 << "Enabling ULPFEC requires rtpmap: red negotiation."; 3844 << "Enabling ULPFEC requires rtpmap: red negotiation.";
3845 EXPECT_EQ(-1, config.red_rtx_payload_type) 3845 EXPECT_EQ(-1, config.red_rtx_payload_type)
3846 << "Enabling RTX in ULPFEC requires rtpmap: rtx negotiation."; 3846 << "Enabling RTX in ULPFEC requires rtpmap: rtx negotiation.";
3847 } 3847 }
3848 3848
3849 void VerifyEmptyFlexfecConfig(const FlexfecConfig& config) { 3849 void VerifyEmptyFlexfecConfig(
3850 EXPECT_EQ(-1, config.flexfec_payload_type) 3850 const VideoSendStream::Config::Rtp::Flexfec& config) {
3851 EXPECT_EQ(-1, config.payload_type)
3851 << "Enabling FlexFEC requires rtpmap: flexfec negotiation."; 3852 << "Enabling FlexFEC requires rtpmap: flexfec negotiation.";
3852 EXPECT_EQ(0U, config.flexfec_ssrc) 3853 EXPECT_EQ(0U, config.ssrc)
3853 << "Enabling FlexFEC requires ssrc-group: FEC-FR negotiation."; 3854 << "Enabling FlexFEC requires ssrc-group: FEC-FR negotiation.";
3854 EXPECT_TRUE(config.protected_media_ssrcs.empty()) 3855 EXPECT_TRUE(config.protected_media_ssrcs.empty())
3855 << "Enabling FlexFEC requires ssrc-group: FEC-FR negotiation."; 3856 << "Enabling FlexFEC requires ssrc-group: FEC-FR negotiation.";
3856 } 3857 }
3857 3858
3858 TEST_P(EndToEndTest, VerifyDefaultSendConfigParameters) { 3859 TEST_P(EndToEndTest, VerifyDefaultSendConfigParameters) {
3859 VideoSendStream::Config default_send_config(nullptr); 3860 VideoSendStream::Config default_send_config(nullptr);
3860 EXPECT_EQ(0, default_send_config.rtp.nack.rtp_history_ms) 3861 EXPECT_EQ(0, default_send_config.rtp.nack.rtp_history_ms)
3861 << "Enabling NACK require rtcp-fb: nack negotiation."; 3862 << "Enabling NACK require rtcp-fb: nack negotiation.";
3862 EXPECT_TRUE(default_send_config.rtp.rtx.ssrcs.empty()) 3863 EXPECT_TRUE(default_send_config.rtp.rtx.ssrcs.empty())
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
4065 std::unique_ptr<VideoEncoder> encoder_; 4066 std::unique_ptr<VideoEncoder> encoder_;
4066 std::unique_ptr<VideoDecoder> decoder_; 4067 std::unique_ptr<VideoDecoder> decoder_;
4067 rtc::CriticalSection crit_; 4068 rtc::CriticalSection crit_;
4068 int recorded_frames_ GUARDED_BY(crit_); 4069 int recorded_frames_ GUARDED_BY(crit_);
4069 } test(this); 4070 } test(this);
4070 4071
4071 RunBaseTest(&test); 4072 RunBaseTest(&test);
4072 } 4073 }
4073 4074
4074 } // namespace webrtc 4075 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698