webrtc/base/macutils.cc - Issue 2620303003: Replace ASSERT by RTC_DCHECK in all non-test code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/macutils.cc

Issue 2620303003: Replace ASSERT by RTC_DCHECK in all non-test code. (Closed)

Patch Set: Also replace NDEBUG checks in taskrunner.h. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/base/macutils.cc

diff --git a/webrtc/base/macutils.cc b/webrtc/base/macutils.cc

index c28ac69b4e68aa8dfedea413a9c36e48b6c701be..794f451dcd2c1408a95166e379cedbd3ee75bb27 100644

--- a/webrtc/base/macutils.cc

+++ b/webrtc/base/macutils.cc

@@ -73,7 +73,7 @@ void DecodeFourChar(UInt32 fc, std::string* out) {

}

static bool GetOSVersion(int* major, int* minor, int* bugfix) {

- ASSERT(major && minor && bugfix);

+ RTC_DCHECK(major && minor && bugfix);

struct utsname uname_info;

if (uname(&uname_info) != 0)

return false;